Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: 杨弋 <yangyi@moonshot.ai>
Cc: Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
	Baojun Xu <baojun.xu@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: tas2781: reject too-short writes to acoustic_ctl debugfs
Date: Sun, 10 May 2026 10:27:11 +0900	[thread overview]
Message-ID: <af_e702o0i96rIMT@sirena.co.uk> (raw)
In-Reply-To: <97bd47532c39bf4406842528adc5883ce43bdb25.b9dfca8f.30b3.4f6f.ab3f.1a908222cdea@feishu.cn>

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

On Sun, May 10, 2026 at 01:51:54AM +0800, 杨弋 wrote:
> The acoustic_ctl_write debugfs handler allocates a buffer via 
> memdup_user(from, count) but only validates that count is not too 
> large. It then accesses src[0] through src[6] without ensuring
> count >= 7.
> 
> Add a minimum-size check of 7 bytes.
> 
> Signed-off-by: Yi Yang <yangyi@msh.team>
> Assisted-by: kimi-cli:kimi-k2.6

You haven't provided a good signoff here, the name and email you're
using here don't obviously correspond to those used in the email body.
Please see Documentation/process/submitting-patches.rst for details
on what this is and why it's important.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2026-05-10  1:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-09 17:51 [PATCH] ASoC: tas2781: reject too-short writes to acoustic_ctl debugfs 杨弋
2026-05-10  1:27 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af_e702o0i96rIMT@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=baojun.xu@ti.com \
    --cc=kevin-lu@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.com \
    --cc=yangyi@moonshot.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox