From: Mark Brown <broonie@kernel.org>
To: Zhang Yi <zhangyi@everest-semi.com>
Cc: tiwai@suse.com, linux-sound@vger.kernel.org,
peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
ckeepax@opensource.cirrus.com, vkoul@kernel.org
Subject: Re: [PATCH v14 3/6] ASoC: es9356-sdca: Add ES9356 SDCA driver
Date: Thu, 14 May 2026 16:11:02 +0900 [thread overview]
Message-ID: <agV1hrh3bY-RdT9q@sirena.co.uk> (raw)
In-Reply-To: <20260513031554.5422-4-zhangyi@everest-semi.com>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Wed, May 13, 2026 at 11:15:51AM +0800, Zhang Yi wrote:
> This is the codec driver for es9356-sdca.
>
> Signed-off-by: Zhang Yi <zhangyi@everest-semi.com>
This breaks a build with -Werror like allmodconfig:
/build/stage/linux/sound/soc/codecs/es9356.c:1144:19: error: initialization of ‘
void (*)(struct sdw_slave *)’ from incompatible pointer type ‘int (*)(struct sdw
_slave *)’ [-Wincompatible-pointer-types]
1144 | .remove = es9356_sdw_remove,
| ^~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/codecs/es9356.c:1144:19: note: (near initialization
for ‘es9356_sdw_driver.remove’)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-14 7:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 3:15 [PATCH v14 0/6] Add es9356 focused SoundWire CODEC Zhang Yi
2026-05-13 3:15 ` [PATCH v14 1/6] ASoC: sdw_utils: add soc_sdw_es9356 Zhang Yi
2026-05-13 3:15 ` [PATCH v14 2/6] ASoC: sdw_utils: add ES9356 in codec_info_list Zhang Yi
2026-05-13 3:15 ` [PATCH v14 3/6] ASoC: es9356-sdca: Add ES9356 SDCA driver Zhang Yi
2026-05-14 7:11 ` Mark Brown [this message]
2026-05-13 3:15 ` [PATCH v14 4/6] ASoC: Intel: soc-acpi: arl: Add es9356 support Zhang Yi
2026-05-13 3:15 ` [PATCH v14 5/6] ASoC: Intel: sof_sdw: add " Zhang Yi
2026-05-13 3:15 ` [PATCH v14 6/6] soundwire: intel_auxdevice: Add es9356 to wake_capable_list Zhang Yi
2026-05-13 15:39 ` Vinod Koul
2026-05-14 1:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agV1hrh3bY-RdT9q@sirena.co.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox