Re: [PATCH v15 3/6] ASoC: es9356-sdca: Add ES9356 SDCA driver

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Thu, May 14, 2026 at 03:52:03PM +0800, Zhang Yi wrote:
> This is the codec driver for es9356-sdca.
> 
> Signed-off-by: Zhang Yi <zhangyi@everest-semi.com>
> ---
> +static int es9356_sdca_dev_resume(struct device *dev)
> +{
> +	struct sdw_slave *slave = dev_to_sdw_dev(dev);
> +	struct es9356_sdw_priv *es9356 = dev_get_drvdata(dev);
> +	unsigned long time;
> +
> +	if (!slave->unattach_request) {
> +		es9356->disable_irq = false;
> +		goto regmap_sync;
> +	}
> +
> +	time = wait_for_completion_timeout(&slave->initialization_complete,
> +				msecs_to_jiffies(es9356_PROBE_TIMEOUT));
> +	if (!time) {
> +		dev_err(&slave->dev, "Initialization not complete, timed out\n");
> +		sdw_show_ping_status(slave->bus, true);
> +
> +		return -ETIMEDOUT;
> +	}
> +
> +regmap_sync:
> +	slave->unattach_request = 0;
> +	regcache_cache_only(es9356->regmap, false);
> +	regcache_sync(es9356->regmap);
> +	return 0;
> +}

This should be updated to use sdw_slave_wait_for_init(), as per:

https://lore.kernel.org/linux-sound/177858284069.1043532.13233320271274458583.b4-ty@b4/T/#m58ed8c01e7e96c991c8f05b636e36bc65cde8add

Thanks,
Charles