From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "Lee Jones" <lee@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"James Ogletree" <jogletre@opensource.cirrus.com>,
"Fred Treven" <fred.treven@cirrus.com>,
"Ben Bright" <ben.bright@cirrus.com>,
"Support Opensource" <support.opensource@diasemi.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Kevin Hilman" <khilman@baylibre.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Andreas Werner" <andreas.werner@men.de>,
"Samuel Kayode" <samkay014@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, linux-renesas-soc@vger.kernel.org,
linux-sound@vger.kernel.org, linux-omap@vger.kernel.org,
imx@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 13/23] mfd: Use named initializers for arrays of i2c_device_id
Date: Wed, 8 Jul 2026 13:12:36 +0100 [thread overview]
Message-ID: <ak4+tEBnZAhohI1n@opensource.cirrus.com> (raw)
In-Reply-To: <5aec0fc2ac0cd1d2e27027ad0c180e2647bd494e.1783507945.git.u.kleine-koenig@baylibre.com>
On Wed, Jul 08, 2026 at 01:15:20PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> i2c_device_id that replaces .driver_data by an anonymous union.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> drivers/mfd/arizona-i2c.c | 12 ++++++------
> drivers/mfd/cs40l50-i2c.c | 2 +-
> drivers/mfd/madera-i2c.c | 18 +++++++++---------
> drivers/mfd/wm831x-i2c.c | 14 +++++++-------
> drivers/mfd/wm8350-i2c.c | 6 +++---
> drivers/mfd/wm8400-core.c | 2 +-
> drivers/mfd/wm8994-core.c | 8 ++++----
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-07-08 12:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 11:15 [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 11/23] mfd: Use named initializers for acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:07 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 13/23] mfd: Use named initializers for arrays of i2c_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 12:12 ` Charles Keepax [this message]
2026-07-08 12:55 ` André Draszik
2026-07-08 11:15 ` [PATCH v2 17/23] mfd: Use named initializers for arrays of spi_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 12:14 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 18/23] mfd: Unify style of acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:20 ` Andy Shevchenko
2026-07-08 12:14 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 21/23] mfd: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:18 ` Charles Keepax
2026-07-08 12:58 ` André Draszik
2026-07-10 19:36 ` Linus Walleij
2026-07-08 11:34 ` [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Andy Shevchenko
2026-07-09 16:08 ` Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak4+tEBnZAhohI1n@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=aaro.koskinen@iki.fi \
--cc=alexandre.torgue@foss.st.com \
--cc=andre.draszik@linaro.org \
--cc=andreas.werner@men.de \
--cc=andreas@kemnade.info \
--cc=andy@kernel.org \
--cc=ben.bright@cirrus.com \
--cc=cw00.choi@samsung.com \
--cc=fred.treven@cirrus.com \
--cc=imx@lists.linux.dev \
--cc=jogletre@opensource.cirrus.com \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mfd@lists.linux.dev \
--cc=michael.hennerich@analog.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=rogerq@kernel.org \
--cc=samkay014@gmail.com \
--cc=support.opensource@diasemi.com \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox