Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Baojun Xu <baojun.xu@ti.com>
Cc: broonie@kernel.org, tiwai@suse.de, 13916275206@139.com,
	alsa-devel@alsa-project.org, shenghao-ding@ti.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	k-yi@ti.com, henry.lo@ti.com, robinchen@ti.com,
	niranjan.hy@ti.com
Subject: Re: [PATCH v1] ASoC: Intel: soc-acpi-ptl-match: add tas2783 support
Date: Mon, 29 Jun 2026 09:15:10 +0300	[thread overview]
Message-ID: <akINbu52R7PJA65Z@ashevche-desk.local> (raw)
In-Reply-To: <20260628122543.757-1-baojun.xu@ti.com>

On Sun, Jun 28, 2026 at 08:25:43PM +0800, Baojun Xu wrote:
> Added tas2783 support in some projects.

...

> +static const struct snd_soc_acpi_adr_device tas2783_0_adr[] = {
> +	{
> +		.adr = 0x0000300102278301ull,
> +		.num_endpoints = ARRAY_SIZE(tas2783_endpoints),
> +		.endpoints = tas2783_endpoints,
> +		.name_prefix = "tas2783"

Leave trailing comma for the non-terminator entries.

> +	}
> +};

...

> +static const struct snd_soc_acpi_adr_device tas2783_2_adr[] = {
> +	{
> +		/* left */
> +		.adr = 0x0000390102000001ull,
> +		.num_endpoints = 1,
> +		.endpoints = &spk_r_endpoint,
> +		.name_prefix = "tas2783-1"

Ditto.

> +	},
> +	{
> +		/* right */
> +		.adr = 0x00003c0102000001ull,
> +		.num_endpoints = 1,
> +		.endpoints = &spk_r_endpoint,
> +		.name_prefix = "tas2783-2"

Ditto.

> +	},
> +};

...

...and so on for Intel case.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-06-29  6:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-28 12:25 [PATCH v1] ASoC: Intel: soc-acpi-ptl-match: add tas2783 support Baojun Xu
2026-06-29  2:03 ` Liao, Bard
2026-06-29  6:15 ` Andy Shevchenko [this message]
2026-06-29  8:16 ` Cezary Rojewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akINbu52R7PJA65Z@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=13916275206@139.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=henry.lo@ti.com \
    --cc=k-yi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=niranjan.hy@ti.com \
    --cc=robinchen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox