From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
James Ogletree <jogletre@opensource.cirrus.com>,
Fred Treven <fred.treven@cirrus.com>,
Ben Bright <ben.bright@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Maciej Strozek <mstrozek@opensource.cirrus.com>,
Mac Chiang <mac.chiang@intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kees Cook <kees@kernel.org>,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] ASoC: Use named initializers for platform_device_id arrays
Date: Mon, 20 Jul 2026 09:23:59 +0100 [thread overview]
Message-ID: <al3bH0vpePggracI@opensource.cirrus.com> (raw)
In-Reply-To: <a76e26aa4edb901b4bea684919463b2243dd8d9d.1784528081.git.u.kleine-koenig@baylibre.com>
On Mon, Jul 20, 2026 at 08:23:49AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Named initializers are better readable and more robust to changes of the
> struct definition. This robustness is relevant for a planned change to
> struct platform_device_id replacing .driver_data by an anonymous union.
>
> While touching these arrays unify spacing and usage of commas.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-07-20 8:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 6:23 [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-20 6:23 ` [PATCH v2 1/6] ASoC: codecs: mt6357: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-20 6:23 ` [PATCH v2 2/6] ASoC: renesas: fsi: Drop platform probing metadata Uwe Kleine-König (The Capable Hub)
2026-07-20 23:12 ` Kuninori Morimoto
2026-07-20 6:23 ` [PATCH v2 3/6] ASoC: amd: acp: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-21 3:48 ` Mukunda,Vijendar
2026-07-20 6:23 ` [PATCH v2 4/6] ASoC: amd: acp: Unify code style for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-20 7:05 ` Cezary Rojewski
2026-07-20 11:32 ` Uwe Kleine-König (The Capable Hub)
2026-07-21 3:49 ` Mukunda,Vijendar
2026-07-20 6:23 ` [PATCH v2 5/6] ASoC: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-20 8:23 ` Charles Keepax [this message]
2026-07-20 6:23 ` [PATCH v2 6/6] ASOC: Unify code style " Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al3bH0vpePggracI@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=ben.bright@cirrus.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=david.rhodes@cirrus.com \
--cc=fred.treven@cirrus.com \
--cc=jogletre@opensource.cirrus.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kees@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=mstrozek@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox