Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Shuming [范書銘]" <shumingf@realtek.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"Flove(HsinFu)" <flove@realtek.com>,
	"Oder Chiou" <oder_chiou@realtek.com>,
	"Jack Yu" <jack.yu@realtek.com>,
	"Derek [方德義]" <derek.fang@realtek.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>
Subject: Re: [PATCH] ASoC: rt766: add RT766/RT767 SDCA driver
Date: Wed, 22 Jul 2026 14:19:58 +0100	[thread overview]
Message-ID: <amDDfsCnhdq/I0X1@opensource.cirrus.com> (raw)
In-Reply-To: <3f470a3c2e2f4123b93c5671dd92fae9@realtek.com>

On Tue, Jul 21, 2026 at 07:10:00AM +0000, Shuming [范書銘] wrote:
> > > +
> > > +     *out_rates = rates;
> > > +
> > > +     dev_dbg(dev, "%s: entity %s supports rates 0x%08x,
> > clock_rates=0x%08x\n",
> > > +             __func__, entity->label, rates, clock_rates);
> > > +
> > > +     return 0;
> > > +}
> > 
> > This is mostly just populate_rate_format(), the values end up in the
> > snd_soc_pcm_stream, can we export that and use it here?
> 
> Sure, will try to export populate_rate_format() and use it here.

Looking a bit more is there really anything that would stop you
just using sdca_asoc_populate_dais(), which is already exported?
You would probably want to fixup the channels_max at the end and
the naming of the DAIs would end up being slightly more SDCA,
but those don't seem like huge problems.

Thanks,
Charles

      parent reply	other threads:[~2026-07-22 13:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20  9:06 [PATCH] ASoC: rt766: add RT766/RT767 SDCA driver shumingf
2026-07-20 14:38 ` Pierre-Louis Bossart
2026-07-21  7:09   ` Shuming [范書銘]
2026-07-20 16:21 ` Charles Keepax
2026-07-21  7:10   ` Shuming [范書銘]
2026-07-21 10:29     ` Charles Keepax
2026-07-22 13:19     ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amDDfsCnhdq/I0X1@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=jack.yu@realtek.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=shumingf@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox