From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Maciej Strozek <mstrozek@opensource.cirrus.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/8] ASoC: SDCA: enable on DT platforms and add Qualcomm WCD9378 (Tambora) codec
Date: Thu, 30 Jul 2026 10:08:37 +0100 [thread overview]
Message-ID: <amsUlWAueA51eSDC@opensource.cirrus.com> (raw)
In-Reply-To: <cedd89d4-28ec-4a86-99ab-249637d81736@kernel.org>
On Wed, Jul 29, 2026 at 01:41:57PM +0200, Krzysztof Kozlowski wrote:
> On 23/07/2026 12:17, Charles Keepax wrote:
> > On Thu, Jul 23, 2026 at 12:42:10AM +0100, Srinivas Kandagatla wrote:
> >> At Linux Plumbers 2025 in the Devicetree MC I raised the "SDCA and the
> >> classic ACPI-DT problem" [1]: MIPI SDCA is built around ACPI/DisCo
> >> firmware descriptors, and the in-tree ASoC SDCA framework
> >> (sound/soc/sdca/) enumerates functions, entities, controls and PDEs by
> >> walking those tables. On ARM64 DT platforms there is no DisCo, so the
> >> framework is unreachable and sdca codecs will not be able to use the
> >> generic sdca drivers and duplicating.
> >>
> >> The direction from that discussion was to let DT platforms reuse the
> >> same class/function auxiliary driver plumbing and have codec drivers
> >> supply the small amount of static function/entity metadata that DisCo
> >> would otherwise carry, plus hooks for device-specific bring-up. This
> >> series is a first cut at that, with the Qualcomm WCD9378 ("Tambora")
> >> SDCA codec on the Glymur CRD as the first consumer. Static table that in
> >> part of this codec is generated from acpi tables.
> >
> > Fascinating, a shame I missed the discussion. Main question
> > I have is what was the reasoning behind using static tables
> > rather than just putting the data in device tree? All the core
> > code uses the generic firmware parsing function so should be
> > perfectly capable of parsing the data out of device tree. The
> > only bit that is missing is really the sdca_lookup_functions
> > bit you ifdef out, but updating that to also support DT should
> > be pretty simple.
> >
> > Looking through your presentation (thanks for linking that),
> > am I to guess this was mostly a device tree people didn't like
> > the stuff SDCA contains problem? I do see that some of the SDCA
> > stuff isn't an exact match for how Linux has traditionally liked
> > to handle DT but also really not sure I see any benefit to DT
> > and ACPI support being different.
>
> We do not describe in DT properties which are implied/deducible from the
> compatible, because it is redundant and we do not like redundancy.
>
> The device is WCD9378 as defined by compatible, thus all or most of SDCA
> properties do not belong to DT.
Do we really want to take this line? It basically forces us to
do "board files" again, which is the problem DT was solving in
the first place. I can't speak for Qualcomm, but at least for
our devices the SDCA properties can change a fair amount
between different laptops.
Also there is the fact SDCA is already a thing and is gaining a
fair amount of traction pushing against it does really feel like
it is just making life much harder for ourselves.
Thanks,
Charles
next prev parent reply other threads:[~2026-07-30 9:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 23:42 [RFC PATCH 0/8] ASoC: SDCA: enable on DT platforms and add Qualcomm WCD9378 (Tambora) codec Srinivas Kandagatla
2026-07-22 23:42 ` [RFC PATCH 1/8] ASoC: SDCA: hw_params: program upstream Input Terminals for OT DAI Srinivas Kandagatla
2026-07-24 13:14 ` Charles Keepax
2026-07-24 13:53 ` Charles Keepax
2026-07-24 16:35 ` Srinivas Kandagatla
2026-07-27 8:33 ` Charles Keepax
2026-07-27 12:42 ` Srinivas Kandagatla
2026-07-22 23:42 ` [RFC PATCH 2/8] ASoC: SDCA: allow building without ACPI Srinivas Kandagatla
2026-07-22 23:42 ` [RFC PATCH 3/8] ASoC: SDCA: expose class helpers with hw_ops for non-DisCo platforms Srinivas Kandagatla
2026-07-22 23:42 ` [RFC PATCH 4/8] ASoC: SDCA: add PDE pre/post-pmu hooks to hw_ops Srinivas Kandagatla
2026-07-22 23:42 ` [RFC PATCH 5/8] ASoC: SDCA: class_function: xlate sound-dai cell by entity index Srinivas Kandagatla
2026-07-22 23:42 ` [RFC PATCH 6/8] ASoC: SDCA: register SDCA_FUNCTION_TYPE_SIMPLE_JACK in class function driver Srinivas Kandagatla
2026-07-23 10:55 ` Charles Keepax
2026-07-22 23:42 ` [RFC PATCH 7/8] dt-bindings: sound: qcom: add Tambora WCD9378 SDCA codec Srinivas Kandagatla
2026-07-23 9:14 ` Konrad Dybcio
2026-07-23 13:28 ` Srinivas Kandagatla
2026-07-23 13:31 ` Konrad Dybcio
2026-07-29 11:40 ` Krzysztof Kozlowski
2026-07-29 12:17 ` Srinivas Kandagatla
2026-07-29 12:30 ` Krzysztof Kozlowski
2026-07-29 12:36 ` Srinivas Kandagatla
2026-07-29 12:43 ` Krzysztof Kozlowski
2026-07-29 13:02 ` Srinivas Kandagatla
2026-07-29 13:23 ` Krzysztof Kozlowski
2026-07-29 13:34 ` Srinivas Kandagatla
2026-07-29 14:04 ` Krzysztof Kozlowski
2026-07-29 17:23 ` Jorijn van der Graaf
2026-07-22 23:42 ` [RFC PATCH 8/8] ASoC: codecs: add Qualcomm Tambora (WCD9378) " Srinivas Kandagatla
2026-07-23 10:17 ` [RFC PATCH 0/8] ASoC: SDCA: enable on DT platforms and add Qualcomm WCD9378 (Tambora) codec Charles Keepax
2026-07-23 13:24 ` Srinivas Kandagatla
2026-07-24 12:36 ` Charles Keepax
2026-07-24 14:31 ` Srinivas Kandagatla
2026-07-24 15:40 ` Charles Keepax
2026-07-24 16:29 ` Srinivas Kandagatla
2026-07-29 11:14 ` Srinivas Kandagatla
2026-07-29 11:41 ` Krzysztof Kozlowski
2026-07-30 9:08 ` Charles Keepax [this message]
2026-07-30 9:11 ` Krzysztof Kozlowski
2026-07-30 10:20 ` Charles Keepax
2026-07-23 19:40 ` Jorijn van der Graaf
2026-07-24 12:17 ` Srinivas Kandagatla
2026-07-24 19:14 ` Jorijn van der Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amsUlWAueA51eSDC@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jorijnvdgraaf@catcrafts.net \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mstrozek@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.dev \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox