From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Cristian La Spina <cristian.laspina@kernel.srl>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: Intel: soc-acpi-intel-ptl-match: add cs42l43_cs35l57_l0 support
Date: Mon, 3 Aug 2026 10:48:16 +0100 [thread overview]
Message-ID: <anBj4B4Rv44EFqoL@opensource.cirrus.com> (raw)
In-Reply-To: <9f71658a-9b12-41c4-8514-19dcf0521146@opensource.cirrus.com>
On Mon, Aug 03, 2026 at 10:06:18AM +0100, Richard Fitzgerald wrote:
> On 02/08/2026 4:57 pm, Cristian La Spina wrote:
> > The Lenovo Yoga 9 2-in-1 14IPH11 puts its CS42L43 codec and both CS35L57
> > amplifiers on SoundWire link 0, as described by its DSDT:
>
> <SNIP>
>
> > so this laptop matches nothing at all
> That is expected. PTL and beyond should be using function topologies,
> not legacy match tables.
>
> > and no
> > card is created: speakers, headphone jack and microphones are all
> > silent, leaving HDMI as the only output.
>
> That is not expected. Please provide dmesg output. You can create a bug
> report at https://github.com/thesofproject/linux and attach it there.
>
> > Add a match for that layout.
> Please don't add match table entries unless there is some reason why
> functional topology is impossible on a system. There shouldn't be any
> need for match tables for this. It can cause problems because it will
> match any system that has that combination of devices even if it also
> has other devices, so it can "capture" a system that was previously
> working with function topologies.
Yeah everything needed for this laptop should be upstream now
(the last patch is still making it's way out of Vinod's SoundWire
tree into Linus's tree), primary discussion was on here:
https://github.com/thesofproject/linux/issues/5801
All the patches can be found here:
https://github.com/charleskeepax/linux/commits/v7.0-cs42l43/
Thanks,
Charles
prev parent reply other threads:[~2026-08-03 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 15:57 [PATCH] ASoC: Intel: soc-acpi-intel-ptl-match: add cs42l43_cs35l57_l0 support Cristian La Spina
2026-08-03 9:06 ` Richard Fitzgerald
2026-08-03 9:48 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anBj4B4Rv44EFqoL@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=cristian.laspina@kernel.srl \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox