Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: shumingf@realtek.com, lgirdwood@gmail.com,
	linux-sound@vger.kernel.org, lars@metafoo.de, flove@realtek.com,
	oder_chiou@realtek.com, jack.yu@realtek.com,
	derek.fang@realtek.com, pierre-louis.bossart@linux.dev
Subject: Re: [PATCH v5] ASoC: rt766: add RT766/RT767 SDCA driver
Date: Tue, 4 Aug 2026 16:55:26 +0100	[thread overview]
Message-ID: <anILbp5sytyR7rGz@opensource.cirrus.com> (raw)
In-Reply-To: <2fd91870-51d8-4604-a281-36b6c234d737@sirena.org.uk>

On Tue, Aug 04, 2026 at 04:01:44PM +0100, Mark Brown wrote:
> On Tue, Aug 04, 2026 at 06:48:28PM +0800, shumingf@realtek.com wrote:
> > From: Shuming Fan <shumingf@realtek.com>
> > 
> > This patch adds the initial SDCA multi-function codec driver for the RT766 and RT767.
> 
> This breaks the build:
> 
> /build/stage/linux/sound/soc/codecs/rt766-sdca.c: In function ‘rt766_sdca_irq_ct
> l’:
> /build/stage/linux/sound/soc/codecs/rt766-sdca.c:240:41: error: implicit declaration of function ‘sdca_irq_cleanup_late’; did you mean ‘sdca_irq_cleanup’? [-Wimplicit-function-declaration]
>   240 |                                         sdca_irq_cleanup_late(dev, function, info);
>       |                                         ^~~~~~~~~~~~~~~~~~~~~
>       |                                         sdca_irq_cleanup
> /build/stage/linux/sound/soc/codecs/rt766-sdca.c: In function ‘rt766_sdca_probe’:
> /build/stage/linux/sound/soc/codecs/rt766-sdca.c:858:35: error: implicit declaration of function ‘devm_sdca_irq_allocate’; did you mean ‘sdca_irq_allocate’? [-Wimplicit-function-declaration]
>   858 |                 rt766->irq_info = devm_sdca_irq_allocate(dev, rt766->regmap, rt766->slave->irq);
>       |                                   ^~~~~~~~~~~~~~~~~~~~~~
>       |                                   sdca_irq_allocate
> /build/stage/linux/sound/soc/codecs/rt766-sdca.c:858:33: error: assignment to ‘struct sdca_interrupt_info *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
>   858 |                 rt766->irq_info = devm_sdca_irq_allocate(dev, rt766->regmap, rt766->slave->irq);
>       |                                 ^
> 

I think this might just be a topic branches thing, those functions
were introduced by my recent series which should be in your tree:

https://lore.kernel.org/linux-sound/178517447302.50339.1499803314056469107.b4-ty@b4/

Thanks,
Charles

  reply	other threads:[~2026-08-04 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 10:48 [PATCH v5] ASoC: rt766: add RT766/RT767 SDCA driver shumingf
2026-08-04 11:58 ` Charles Keepax
2026-08-04 15:01 ` Mark Brown
2026-08-04 15:55   ` Charles Keepax [this message]
2026-08-04 16:05     ` Mark Brown
2026-08-04 16:42 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anILbp5sytyR7rGz@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=jack.yu@realtek.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=shumingf@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox