From: Mark Brown <broonie@kernel.org>
To: wangdich9700@163.com
Cc: srini@kernel.org, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, wangdicheng@kylinos.cn
Subject: Re: [PATCH 2/3] ASoC: qcom: lpass-hdmi: fix invalid rate error message
Date: Wed, 2 Sep 2026 15:45:09 +0100 [thread overview]
Message-ID: <apg2dTjMXjeBdnto@sirena.org.uk> (raw)
In-Reply-To: <20260902071943.522194-3-wangdich9700@163.com>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Wed, Sep 02, 2026 at 03:19:42PM +0800, wangdich9700@163.com wrote:
> From: wangdicheng <wangdicheng@kylinos.cn>
>
> The sampling rate switch reused the bitwidth error path, so an
> unsupported rate logged "invalid bit width" with the bitwidth value.
> Print the rate instead.
> default:
> - dev_err(dai->dev, "%s invalid bit width given : %d\n",
> - __func__, bitwidth);
> + dev_err(dai->dev, "%s invalid sampling rate given : %d\n",
rate is unsigned; I am surprised you don't get compiler warnings about
that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-02 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 7:19 [PATCH 0/3] ASoC: qcom: misc fixes for LPASS driver wangdich9700
2026-09-02 7:19 ` [PATCH 1/3] ASoC: qcom: fix assorted whitespace issues wangdich9700
2026-09-02 7:19 ` [PATCH 2/3] ASoC: qcom: lpass-hdmi: fix invalid rate error message wangdich9700
2026-09-02 14:45 ` Mark Brown [this message]
2026-09-02 7:19 ` [PATCH 3/3] ASoC: qcom: fix VA CDC DMA DAI range handling wangdich9700
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apg2dTjMXjeBdnto@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
--cc=wangdich9700@163.com \
--cc=wangdicheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox