From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63E83592207 for ; Tue, 8 Sep 2026 15:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788883090; cv=none; b=UI0lW7o9JocjfdfgQYpeFLLiuNtCx15Ic6rOJrcOCffDjDhjU0ojUdjH7rIg1ih9wySOx+4wj2qubHVuwpc3vLZnuqAQL9q2qVZmiW8oNZPQJkASee3HRwLiwhKytV+Le4ZN5viR4JNUMbH979nYU0jTmYDefG8R8nQZL0OedvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788883090; c=relaxed/simple; bh=HCOjmtuIURC8etW7PMldOk8sZqet30nx4hUSBGF2CaM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ihPMtueTMbko9J+6Z+aY4UsuJ3Rm8rcrQp22+0LdyV7dielJ9/1XxZDwaT2cqvvVGVMiJ1NU+nLb5Y9t2PbdlRjWO6kidVj589nAC+6JdbUpB9PxMdcpMAaWtm5SLet/4xGWA74/ybaWHzGYiBMfI2GiVsZG1R4/dWhZ8lisiyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=R1wihYgR; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="R1wihYgR" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-485850cf499so3185621f8f.3 for ; Tue, 08 Sep 2026 08:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1788883086; x=1789487886; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=COKTXmW8lCYoLX/NVE9lHsQ1T9j35CdnW3YzobS56+o=; b=R1wihYgRLDUHV4dUomXmKTaBwR50POp7oEB6TzD5CsxU5cGBvanOrj5b/MGM2TbnhB RqgXlGux3WqVJ7wAU77ykLKoLugAOgc5MY13YEI2L8PeaSZZk4X9lt4Yba5Jb1b4NRNO pDqSFhE33y2l1ce4kwcaVi0e1CgYOWUA5OWhuQkgQQH8mkjoAOHQk6fmPf6RnqsFX4+V khy0aO8TEsZbVKRsF/bk+0NX0qbnsmn18pKJQpQZNevFEWvsvDiv5of+RacNp2mLeKRi FMVabifqOWn5F3WUvNFlJ3xXDSG4JMl7l6wpQ5J9WKdGPEaUR6fifhD7d7GhpbjD/gxp pFfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788883086; x=1789487886; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=COKTXmW8lCYoLX/NVE9lHsQ1T9j35CdnW3YzobS56+o=; b=R9aWg9wX5U1nFyMFiNGWwKpNeeAe4s4MOSEmlHa9bcH/xViFEd2Vpt1GN/fbq4P3zX PP57p+I5X7+BO1YUrJKS7yOw2MNHDTfFEXkjop93iKpOrvFll/Z8Rkg6uS1VFIbW611M T5kqPBlJw8FpncRTQW67AroprJixoakbyFd/9d17TYUpJBu+X3rTgSr4iN4a25d4AHHZ vsOw4+tjkGagiDey1IsIMfCtyvHAl8OW6cdlXEkxKYQdYU3jcb4AMsb0DBuLM0Ibp2YS W2GoZWf0F1T5xSn9fF7wFLLpUGdH+k+E+0qBfDoGiP/0F6/munXwqxkW4CJ7KlPMQHUX s1xg== X-Forwarded-Encrypted: i=1; AKwUvBwYBktQY3LeXXwIU357BTt+q491pCLjZCnRFy/Mqdv1CzRct0rK0HZG7cKAwvL7n/TVmRCN7/E0+v8gAw==@vger.kernel.org X-Gm-Message-State: AFuF++lq6d4bp/yWr2V+VTuoyV1ZTZPbFtKqmlAnclo0mCvZXLp7IB1b 4cDSSCjdSaOUYwMgAV2wtCbx2vYLKxwM+yEFFH66w08Ic+eAAzdo1pnsytNdClwlYnc= X-Gm-Gg: AYBFou2AA/zY2T7s1RnboLAEv5hv4SEfStu6wveePR37MrBHT1uN0lCG/76+6d97zXY t7eB6ZJisOlJ+QAjmAc8u1smV9q33St5WV55CWEf3wONehmwegbhnOoiDu1SJljktkS1iBsfa28 BOUi9ZQEhOfGeF26hhdNDFyrZ1eSBdrmKCwrPWMrqW5i+tRPLHH4B1XMuFTyhGZcXpDC70zM4Di +J0IgphjLUB0wM7Ca9PuC22WkwPC0X/Q9RbMVbV4CRZdDYjWFA7Ywg4UPwnNo1ISIN+a/5il8Zc DCONE8u3h/5gKwx6Oo4CsOr0AampaLRC9Yva7ulwx+wWXl4x1AsVqXXgZGHA0hU3XpmYUrsJINt CCa1RVVQDtBX5dPs9NWTcSawubGn7JrSA3zNmcwG4CLEZ/VwbkExf9Cucs7CQ/2xhnU9RCiVnKl uO93reD0DRDtQz5ybaLb0X8+oghmSeAx8aLqh68pGHUJaDeyJ1u1lYouO2EkXJFIda37mf9Wege KDxfbLrsDVjqft3lshyu76BjeMDMzWXWAhmlWy2RDexTcYoTxY= X-Received: by 2002:a05:600c:a0b:b0:49c:cee2:1697 with SMTP id 5b1f17b1804b1-49cf8262133mr304493845e9.16.1788883085916; Tue, 08 Sep 2026 08:58:05 -0700 (PDT) Received: from localhost (p200300f65f19a9042cc2680c1f1bf2f5.dip0.t-ipconnect.de. [2003:f6:5f19:a904:2cc2:680c:1f1b:f2f5]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-48588394fa1sm35076368f8f.8.2026.09.08.08.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 08:58:05 -0700 (PDT) Date: Tue, 8 Sep 2026 17:58:04 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Srinivas Kandagatla Cc: Mark Brown , Rob Herring , Charles Keepax , Krzysztof Kozlowski , Conor Dooley , Bard Liao , Jaroslav Kysela , Liam Girdwood , Maciej Strozek , Pierre-Louis Bossart , Takashi Iwai , Faiz Nabi Kuchay , Jorijn van der Graaf , patches@opensource.cirrus.com, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/11] ASoC: codecs: add Qualcomm Tambora (WCD9378) SDCA codec Message-ID: References: <20260907083727.733705-1-srinivas.kandagatla@oss.qualcomm.com> <20260907083727.733705-12-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="765wben5jmkzogdu" Content-Disposition: inline In-Reply-To: <20260907083727.733705-12-srinivas.kandagatla@oss.qualcomm.com> --765wben5jmkzogdu Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v2 11/11] ASoC: codecs: add Qualcomm Tambora (WCD9378) SDCA codec MIME-Version: 1.0 Hello, On Mon, Sep 07, 2026 at 09:37:25AM +0100, Srinivas Kandagatla wrote: > +#include Please don't include . Either rely on to provide sdw_device_id (my preferred way), or (if you want full iwyu) include . > [...] > +static const struct sdw_device_id wcd9378_sdw_id[] = { > + SDW_SLAVE_ENTRY(0x0217, 0x0110, 0), > + {} > +}; s/{}/{ }/ please to match the common style. > +MODULE_DEVICE_TABLE(sdw, wcd9378_sdw_id); > + > +static struct sdw_driver wcd9378_sdw_driver = { > + .driver = { > + .name = "wcd9378", > + .pm = pm_ptr(&wcd9378_sdw_pm_ops), > + }, > + .probe = wcd9378_sdca_probe, > + .remove = wcd9378_sdca_remove, > + .id_table = wcd9378_sdw_id, > + .ops = &wcd9378_sdw_ops, > +}; subjective feedback: I'm not a fan of aligning the = in such initialisations. They tend to get inconsistent over time, and sometimes (like here) they even start inconsistently. So if you ask me, use a single space before each =. > +module_sdw_driver(wcd9378_sdw_driver); > + > +MODULE_DESCRIPTION("Qualcomm WCD9378 (Tambora) SoundWire codec"); > +MODULE_AUTHOR("Qualcomm Technologies, Inc."); > +MODULE_LICENSE("Dual BSD/GPL"); > +MODULE_IMPORT_NS("SND_SOC_SDCA"); > +MODULE_IMPORT_NS("SND_SOC_SDCA_CLASS"); Best regards Uwe --765wben5jmkzogdu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqgMIkACgkQj4D7WH0S /k7HSggApAsqBk4MvLcFhPNfq1ozMJSIoE+LirT/GzBRY6d7XMtZW8CLtYNiq6Q3 HeZbQlcqOlJ5fT3O6pGkpEwA23r0GX7JtqBOgz39PxQV9CX8l72tcqw6CcQrG2tV qoub2YTQt/7/ZaPAHEhxxcZxWzR1+S02ejC6kf2+4FrySDkUfBdJ3vVD/KKxbyS9 FcMHpBbR9Nv/J01dLTASs9iUWSki8qNwld1+hhfWTFYI7Ho+7Yrt79+LAiUqwJjj Ph2+Toa/P2Zf6i5IFf0K3k9g7HfMxt8WzYTeW5asujYRo0bNQfBk3vj9yqwJveHr H2iSp++GJEzaPEbhyx9imFpQ3voL1A== =cFZA -----END PGP SIGNATURE----- --765wben5jmkzogdu--