From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C5448D885 for ; Thu, 10 Sep 2026 13:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789046818; cv=none; b=cQwUO/HRjv54ypj68P6ns1fhGSUUUDCkhXpYpnHLrVpDjEjv/Do9NGMZZRKFrM7AhGyrkGvSPpYl+ZGVZkAQPJxcezyGHZ7JIEW1ZvXTa4XgJzHdjW8i0rdElmOZG2ZHY5UBN3cnK/6IXGUvMO6KQhxm6Db0wTwPEy5wCJxVmFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789046818; c=relaxed/simple; bh=paNGGPZ1uw4B5jdjVSomKJFoJ+yYw0I2G7m3Tm51ufE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jXwf3xH6bq0B1IHleeyAH/o8vSNdT+IL7SyoHpJLwlnxCMu5aqTtFEeJFqP5SDkGds4v2Tk2NNstnwuOXEdE/9msXRh57Sg2kQjYndoMvUkXqdiPtzC79uUospYH22GESqm95VDpG06trOlGqLg6nIbypGXxbYm0tPtT8kj7X3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=prCPmycF; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="prCPmycF" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6a9a4dc8afeso1194004a12.3 for ; Thu, 10 Sep 2026 06:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789046815; x=1789651615; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=EvtswLvPiQHbO1nAALeYzwdSCfuCoM47IC0JhG2+bnc=; b=prCPmycFvHrebUfIJFkIDMn11uHh2RAgvowahlArJhuRJp7/HSPaHwSylXR1oT5T8b lNgaU+anvgeGf2MeAudcf0MuRBhUNFqf7K86QqmgrNH1zXrlJzDlFG75bz9Lv42UZQhE /NijN0p75Qcd4QFP+6wVlKxDWgWo4Gvhk4wAcKYBfXAuXaPtf/HhNIKGmCx7Xwr2boKL muiJqv8xqs7sKODL+AblyxgelWhmIDAYd9zNalqwv7syLcT8vQ8O1P3hsKGsdNkZ0/QY avmvo59GD0S1u5RuxkTKgvAfxAkI8jJPFYEq+9mAdy22CQEslyWbO2LtQyrsbjvBuojP jpDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789046815; x=1789651615; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EvtswLvPiQHbO1nAALeYzwdSCfuCoM47IC0JhG2+bnc=; b=UmyNCch75bJPNsUjltHIyaXcaW9UY3a+3/Nd3b46xTN/aSoSCyBJSn0MWZyl+0t420 dGNviqOAXWCIGs1j6ErP4E7uFpvcqS3DP2eCDLa9a5TI+ir23dvkzGNjt4wKOzdIrXhd /gRloUUuJbn0LQ3nw78WmT8Ki5ziFdvA65KadJCM55d/zOooVMMOshbdv6GN+Wo0y6rs cBxNcE4ig2LYztwAnRcdBLbWVE6azzNjvMOjL2ku0VA6Qhv5TA9csjnk2r04PSCRoFnK rPkVtDcVQAngzCuRFFDbyHl5Agy5Grs8hHAbmOH2zVwJUkC5WTFnT3Gzd4ZJ5r72oqNM g6Bw== X-Forwarded-Encrypted: i=1; AKwUvBy0eOUzeKlT/px9mwcfsK0Osm9mVKq2Rn+rZ/K2XCTmsasQIUaKjaOHdB6jTn9PaoKRs9OuInWBrJlvmQ==@vger.kernel.org X-Gm-Message-State: AFuF++nEhSlrgc1l9aRfdyJYY9ysBLS8oRrd9HGCmmA4dBS/vKLJVesm 6Z5e2bXwxUw1n0Q6Hq0zWsVubNimdTA+zZV72FCjaKXx3Kjcr6tBoR1h X-Gm-Gg: AYBFou1PcjV8lw5E16bGdFp3+fy7LCwFeAkqfomZgE1YoERBTUjP4oLmv/QKd6t9kPV RSPLcGwNZ9xylh7GZbJtoy6ABo1Qbwu0wPhTE40etPK0Ki0ZpxHkp7A4V+u0jfOv1Z4bvBA+W32 SdRW6eC7as0wBxWL570MWmWnhLT512zlMg86FLZF2yRI2QJzdnJXRrNlEbCyoZ8XLC/lk7Rop83 Rmmm4cDg2bEd26ueFssFZsofNmoJXqCHGb6YKhz50NDKRapk+dQKQfPNSVklE1P8nAGpi3YlIRr wuxUkm5leC+ZpNRy/yZpJ+4+bucgVZkC56T97wWhs0upLjp6dAlj08u6DhoFCW7t7S2fgGNdily 6A0a+BsgttgfhR3Hay7QNtkoZ1p/Nqg/fU1AzRP3FpNXmSLp00lJqUrUbVFp+px91nDrJyMTXPK 2wLfNMYdU83NmXEi3mY4fgDBYqNNUpmLyXAWfh/bKjHv4UV3jdZmgUns1wcm4x+UxgxTmylIsO/ 5ObX6U= X-Received: by 2002:a17:907:a893:b0:c29:286e:2e3e with SMTP id a640c23a62f3a-c29286e30e9mr574563466b.38.1789046815001; Thu, 10 Sep 2026 06:26:55 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c260d6e1c93sm912526366b.63.2026.09.10.06.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 06:26:53 -0700 (PDT) Date: Thu, 10 Sep 2026 16:26:49 +0300 From: Dan Carpenter To: phucduc.bui@gmail.com Cc: Mark Brown , AngeloGioacchino Del Regno , Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/13] ASoC: mediatek: mt8189: Validate sysclk frequency Message-ID: References: <20260910125742.150902-1-phucduc.bui@gmail.com> <20260910125742.150902-12-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260910125742.150902-12-phucduc.bui@gmail.com> On Thu, Sep 10, 2026 at 07:57:40PM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > mtk_dai_i2s_set_sysclk() accepts zero or negative frequencies. ^^^^^^^^^^^^^^^^^^^^ It's unsigned int so it can't be negative. regards, dan carpenter > Reject invalid frequencies before configuring the I2S clock. > > Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") > Signed-off-by: bui duc phuc > --- > sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c > index f20dbb410223..ca7d786cdeff 100644 > --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c > +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c > @@ -1286,6 +1286,9 @@ static int mtk_dai_i2s_set_sysclk(struct snd_soc_dai *dai, > dir != SND_SOC_CLOCK_OUT) > return -EINVAL; > > + if (freq <= 0) > + return -EINVAL; > + > i2s_priv = afe_priv->dai_priv[dai->id]; > if (!i2s_priv) > return -EINVAL; > -- > 2.43.0