From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Fabio Estevam <festevam@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
"J.M.B. Downing" <jonathan.downing@nautel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Vladimir Zapolskiy <vz@mleia.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH 02/21] ASoC: fsl: use .auto_selectable_formats
Date: Fri, 11 Sep 2026 21:10:16 +0100 [thread overview]
Message-ID: <aqRgKGJUn5NGVcdi@sirena.org.uk> (raw)
In-Reply-To: <87wlt3yw5b.wl-kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Thu, Sep 03, 2026 at 01:13:36AM +0000, Kuninori Morimoto wrote:
> We can use .auto_selectable_formats. Let's adds it.
> +static const u64 fsl_audmix_selectable_formats =
> + SND_SOC_POSSIBLE_DAIFMT_DSP_A |
> + SND_SOC_POSSIBLE_DAIFMT_NB_NF |
> + SND_SOC_POSSIBLE_DAIFMT_IB_NF;
> +
> static const struct snd_soc_dai_ops fsl_audmix_dai_ops = {
> .set_fmt = fsl_audmix_dai_set_fmt,
> .trigger = fsl_audmix_dai_trigger,
> + .auto_selectable_formats = &fsl_audmix_selectable_formats,
> + .num_auto_selectable_formats = 1,
> };
>
> static struct snd_soc_dai_driver fsl_audmix_dai[] = {
Are you sure this is safe with DPCM systems that default things to being
linked to the dummy DAI? If we run autoselection during startup and
looks at the dummy then that might not reflect the actual link we end up
with. I think there's similar stuff going on with some of the Mediaktek
and Samsung machines, I'll skip those patches.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
next prev parent reply other threads:[~2026-09-11 20:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 1:13 [PATCH 00/21] ASoC: use .auto_selectable_formats Kuninori Morimoto
2026-09-03 1:13 ` [PATCH 01/21] ASoC: dwc: " Kuninori Morimoto
2026-09-03 1:13 ` [PATCH 02/21] ASoC: fsl: " Kuninori Morimoto
2026-09-03 7:43 ` Vladimir Zapolskiy
2026-09-11 20:10 ` Mark Brown [this message]
2026-09-13 23:55 ` Kuninori Morimoto
2026-09-22 8:35 ` Hsieh Hung-En
2026-09-03 1:13 ` [PATCH 03/21] ASoC: hisilicon: " Kuninori Morimoto
2026-09-03 1:13 ` [PATCH 04/21] ASoC: img: " Kuninori Morimoto
2026-09-03 1:13 ` [PATCH 05/21] ASoC: jz4740: " Kuninori Morimoto
2026-09-03 1:13 ` [PATCH 06/21] ASoC: kirkwood: " Kuninori Morimoto
2026-09-03 1:13 ` [PATCH 07/21] ASoC: loongson: " Kuninori Morimoto
2026-09-03 1:13 ` [PATCH 08/21] ASoC: mediatek: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 09/21] ASoC: mxs: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 10/21] ASoC: pxa: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 11/21] ASoC: renesas: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 12/21] ASoC: rockchip: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 13/21] ASoC: samsung: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 14/21] ASoC: sti: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 15/21] ASoC: stm: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 16/21] ASoC: sunxi: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 17/21] ASoC: tegra: " Kuninori Morimoto
2026-09-04 8:53 ` Jon Hunter
2026-09-03 1:14 ` [PATCH 18/21] ASoC: ti: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 19/21] ASoC: uniphier: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 20/21] ASoC: ux500: " Kuninori Morimoto
2026-09-03 1:14 ` [PATCH 21/21] ASoC: xtensa: " Kuninori Morimoto
2026-09-11 20:12 ` (subset) [PATCH 00/21] ASoC: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqRgKGJUn5NGVcdi@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=festevam@gmail.com \
--cc=jonathan.downing@nautel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox