Re: [PATCH v3 22/26] ASoC: SOF: Add support for IPC4 compressed

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

On Fri, Sep 11, 2026 at 02:21:48PM +0300, Peter Ujfalusi wrote:

> Set and define the compressed ops for IPC4.
> The initial implementation supports basic features: PAUSE PUSH/RELEASE,
> DRAIN and progress reporting.
> Tested with PCM, MP3, AAC and VORBIS codec.

> +static int sof_ipc4_compr_set_params(struct snd_soc_component *component,
> +				     struct snd_compr_stream *cstream,
> +				     struct snd_compr_params *params)
> +{

> +	/* Use correct format based on the used codec */
> +	switch (params->codec.id) {
> +	case SND_AUDIOCODEC_PCM:
> +		snd_mask_set_format(fmt, (snd_pcm_format_t)params->codec.format);
> +		break;

snd_mask_set_fmt() ends up as:

  #define MASK_OFS(i)     ((i) >> 5)

  ...

  static inline void snd_mask_set(struct snd_mask *mask, unsigned int val)
  {
          mask->bits[MASK_OFS(val)] |= MASK_BIT(val);
  }

but we have done no validation on the format and snd_mask only has 63
elements in the array.  That looks like we're allowing writes to go off
beyond the end of the buffer unless I'm misreading things.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]