From: Mark Brown <broonie@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: tiwai@suse.de, linux-sound@vger.kernel.org, bard.liao@intel.com,
peter.ujfalusi@linux.intel.com
Subject: Re: [PATCH 5/7] ASoC: Intel: sof-function-topology-lib: add I2S support for sof_sdw_get_tplg_files
Date: Tue, 22 Sep 2026 15:18:24 +0200 [thread overview]
Message-ID: <arKAIIkESvrODYQ3@sirena.co.uk> (raw)
In-Reply-To: <20260922092316.2296039-6-yung-chuan.liao@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
On Tue, Sep 22, 2026 at 05:23:14PM +0800, Bard Liao wrote:
> The Intel SOF SDW machine drive also supports I2S interface. Add related
> supports for the sof_sdw_get_tplg_files() callback.
> +static int get_ssp_tplg_dev(struct device *dev, struct snd_soc_dai_link *dai_link,
> + u16 *hdmi_in_mask, int *tplg_dev, char **tplg_dev_name)
> +{
> + unsigned int ssp_port;
> +
> + if (sscanf(dai_link->name, "SSP%d", &ssp_port) != 1) {
Should be %u for unsigned, or a regular int for %d.
> + if (strstr(dai_link->name, "Codec")) {
> + /*
> + * Assume DAI link 0 is jack which is true in all existing
> + * machine drivers
How about sof_ssp_amp.c?
> + } else if (strstr(dai_link->name, "HDMI")) {
> + *hdmi_in_mask |= BIT(ssp_port);
> + /* The number of HDMI in dai link is always 2 right now */
> + if (hweight16(*hdmi_in_mask) != 2)
> + return -EINVAL;
> +
> + *tplg_dev = TPLG_DEVICE_SSP_HDMI_IN;
> + *tplg_dev_name = devm_kasprintf(dev, GFP_KERNEL,
> + "ssp%x-hdmiin", *hdmi_in_mask);
Not %d?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-22 13:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 9:23 [PATCH 0/7] ALSA/ASoC: Intel: add I2S function topology support Bard Liao
2026-09-22 9:23 ` [PATCH 1/7] ASoC: SOF: get nhlt from all topologies Bard Liao
2026-09-22 9:23 ` [PATCH 2/7] ALSA: intel-nhlt: lower intel_nhlt_ssp_device_type log level Bard Liao
2026-09-22 9:23 ` [PATCH 3/7] ASoC: Intel: sof-function-topology-lib: create common helpers Bard Liao
2026-09-22 9:23 ` [PATCH 4/7] ASoC: Intel: sof-function-topology-lib: skip non-exist file in best_effort mode Bard Liao
2026-09-22 9:23 ` [PATCH 5/7] ASoC: Intel: sof-function-topology-lib: add I2S support for sof_sdw_get_tplg_files Bard Liao
2026-09-22 13:18 ` Mark Brown [this message]
2026-09-22 13:58 ` Liao, Bard
2026-09-22 14:06 ` Mark Brown
2026-09-22 9:23 ` [PATCH 6/7] ASoC: Intel: sof-function-topology-lib: add get_function_topology for I2S machines Bard Liao
2026-09-22 9:23 ` [PATCH 7/7] ASoC: soc-acpi-intel-ptl-match: I2S machines: use function topology Bard Liao
2026-09-22 13:19 ` [PATCH 0/7] ALSA/ASoC: Intel: add I2S function topology support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arKAIIkESvrODYQ3@sirena.co.uk \
--to=broonie@kernel.org \
--cc=bard.liao@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox