From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CACD2231842 for ; Sat, 26 Sep 2026 14:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790433484; cv=none; b=HiwTe/3+p9o8KuKB4WrL9FCTxwxKnix1r1oUW4ooSNjUcbHy1fuYjDFC5FzXrcPrI6AHR5qhPnCGQfBct8y7qsnLp7eBR1X+FpsUTQ05gF7PQ3y+80PcUxxZghHtj1O1xKzlykDggzqAwT1IIfuDkidrWZW6MDP+LJZRZ/O7lAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790433484; c=relaxed/simple; bh=NtdMJkvpRXEnSa/4Oit1L1q9EKbg2wA93OXP5lY0r1s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fhpRXmDjIJkRRbLy4jsbGyb8k9I8YRWTPZOVSnGXldjOMhia3GxNgwi1E5k388rbTzHEmm/8AsyEt0d/lkGmxyZHF9/REzF/nhLR4OHFExlij/tGCRCKQjGdw8cO3fPIkNwjxQoPUDwgK/D+IRuFwUlR39keFgutpZYbNVKL1Ac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eweI3OCk; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eweI3OCk" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-4843f22dc83so1420203f8f.1 for ; Sat, 26 Sep 2026 07:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790433481; x=1791038281; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BoThG4thxlXrTbw7oMamnALAxxBbKFMtz3aQO6xHoEQ=; b=eweI3OCkW76Yrwqm+MqqjT05T8WaZHjbvwjv04dYuLGw3+loydhLv98XaGQK2rAFZf okKvD7SKS7H57aHVMdYf8Md9LoKlsk4uE0IX3KQzSmK/AgIIlgLENCMvPo4CYSZtzwWq X5yARuZEfyvR1y6V4NhQwmqNK3IB4JfJzissdA+2CT4FkylBGUl9o2qaioISEYPWrX0W K30ZfkaJVUSs3zHkEcg1w/qVqsozSBAw0MC3wTYRgnrk2mj5C4L6t4gNkTJZQhYdJK7Z 67dA46DAhwSoSOC0fIHodgzq96vinFIe+ZkARPc5tstwoWy6Snv2riT4l+DFeoTxCwhW Tfjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790433481; x=1791038281; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BoThG4thxlXrTbw7oMamnALAxxBbKFMtz3aQO6xHoEQ=; b=Md7Taoc4T0w8wLeSt6BY5PGJe/FnHYQ3oFQv9aqan8om64bWVS2ijRp7JHkP9ijIsJ uOSi8UTQV11rI0HzD2aXvqOveohujOQWwmZ7xKQT+MLs1NrtkACGt4XQInng1ff0VxcA 1z0hClIg0Bp7TrOxFxn6GOqKgJbgsfDR58gIgKL/RCyHbOtCWPP6Ixcz9ZoAU/NvqELd yOoF6cnoaQ9ObohODXiVcTqsluWDWMc/HyHLDzC+ZlthATQl2ZBoGKZ1q6ZnS/7BJIPO ETjZuN/J/98WQwaLFqni3qN2fScNRfphCsoldRSSofTtGkNUpITyQd2dNI8DXGrWA7jN bgSw== X-Forwarded-Encrypted: i=1; AKwUvBwTO6Jp4AceAiis0yk7b1gvKFx0v0TD3EdBIdfOrTfa8Wu6TzQFpGtzM/rOnSmSS+Aa1hG4QQcws5S1cw==@vger.kernel.org X-Gm-Message-State: AFq9FYLasNZD8UqQuHbrcBgukGaVsJIRFHV4dtsKBCNyFf4J/m3aiuzq UJYYQsAqfQUpA3CLXpuIVGTtRLgqeie764dJtb9KPk6Dnx4YefAgNfmx X-Gm-Gg: AYBFou3oYbA1SPgd9mNuqfSwUxrczlO4Om2GDgYzr8cQYGxNrr8xwqPNZ7Yzm0PkvgB 5l6cBtgHox3jniw84RzRTWytQ1M0rXHBkQ2bXI5OMSYr7apwlw1w1/UGg2c/3GGA6F3JIfQqrZw RwumASrFCwacPra1lBnhFcj33fXxua6Yi0r8/rPHIXi8NBtCy5dCTMrF9cARSKQYWAvjU7edEwc +RDSyjP1yncLRNwuCMbE0Ps7or/prkq5dJt2cJhPHIiTUFCqpG6zQUgrZgBY4lC170SHtDXVk1s R3eHc1iZR9nAh7yhgXWm+7D5m8aAtHIqRsBlqAfuc+ujex6CY5cRP7YVCY1j6uciQUfTGOJhYvE rH2NSRsYkENPvlxA/dRtvSciUQ3R4t1ioKvVH14E+zkzQwUJ4s10FhRjeShFjiE6NSfawIWhb9m IsGBjdRLP8CM6OUtm8SRu8jcAzEX8EZhb548atLMSDEmLGkK4woLkjK0odzebRjEOMqUi/ubtAC YQczg== X-Received: by 2002:a05:6000:25f7:b0:488:54ff:67c9 with SMTP id ffacd0b85a97d-48872ac7587mr14732310f8f.46.1790433480936; Sat, 26 Sep 2026 07:38:00 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4887a349a0esm20798420f8f.10.2026.09.26.07.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Sep 2026 07:38:00 -0700 (PDT) Date: Sat, 26 Sep 2026 17:37:56 +0300 From: Dan Carpenter To: Slavin Liu Cc: shengjiu.wang@gmail.com, xiubo.lee@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, festevam@gmail.com, nicoleotsuka@gmail.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl_asrc: check the second front-end DMA channel Message-ID: References: <20260913125147.109920-1-bolin.liu@seu.edu.cn> <20260926141011.451552-1-bolin.liu@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260926141011.451552-1-bolin.liu@seu.edu.cn> On Sat, Sep 26, 2026 at 10:10:11PM +0800, Slavin Liu wrote: > Hi Dan, > > On Sat, Sep 26, 2026 at 04:19:38PM +0300, Dan Carpenter wrote: > > The ->get_dma_channel() function pointer returns error pointers not > > NULL. > > > > sound/soc/fsl/fsl_asrc_dma.c:254 fsl_asrc_dma_hw_params() > > warn: 'tmp_chan' is an error pointer or valid > > > > sound/soc/fsl/fsl_easrc.c | (struct fsl_asrc)->get_dma_channel | fsl_easrc_get_dma_channel | 1 > > sound/soc/fsl/fsl_asrc.c | (struct fsl_asrc)->get_dma_channel | fsl_asrc_get_dma_channel | 1 > > Is this a false positive?: both implementations return > dma_request_slave_channel(). Ah, you're looking at old code. It changed from NULL to error pointers last week. The dma_request_slave_channel() function was deleted entirely since there are no more callers in the kernel. https://lore.kernel.org/all/20260918113727.1898998-6-andriy.shevchenko@linux.intel.com/ regards, dan carpenter