From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: HyeongJun An <sammiee5311@gmail.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/13] ASoC: codecs: wm8991: Fix definition of right input PGA controls
Date: Wed, 14 Oct 2026 10:35:26 +0100 [thread overview]
Message-ID: <as9M3j6wBu5ZT2Ck@opensource.cirrus.com> (raw)
In-Reply-To: <5c0196e45dff1769682d885fc26e613648e05436.1791959026.git.sammiee5311@gmail.com>
On Wed, Oct 14, 2026 at 03:32:30PM +0900, HyeongJun An wrote:
> The right input PGA boost (R12MNBST, R34MNBST) and routing (R12MNB,
> R34MNB) bits are in Input Mixer4 (R42), not in Input Mixer3 (R41),
> where these controls write the left channel bits.
>
> Fixes: 203db220718c ("ASoC: WM8991: Add initial WM8991 driver")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Again makes sense as per the headers.
Thanks,
Charles
next prev parent reply other threads:[~2026-10-14 9:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 6:32 [PATCH 00/13] ASoC: codecs: Fix Wolfson control definitions that write another control's bits HyeongJun An
2026-10-14 6:32 ` [PATCH 01/13] ASoC: codecs: wm8990: Fix definition of right input PGA controls HyeongJun An
2026-10-14 9:32 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 02/13] ASoC: codecs: wm8990: Fix definition of LOMIX AINLMUX Bypass Volume control HyeongJun An
2026-10-14 9:32 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 03/13] ASoC: codecs: wm8991: Fix definition of right input PGA controls HyeongJun An
2026-10-14 9:35 ` Charles Keepax [this message]
2026-10-14 6:32 ` [PATCH 04/13] ASoC: codecs: wm8991: Fix definition of LOMIX AINLMUX Bypass Volume control HyeongJun An
2026-10-14 9:35 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 05/13] ASoC: codecs: wm8983: Fix definition of ADC 128x Oversampling control HyeongJun An
2026-10-14 9:39 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 06/13] ASoC: codecs: wm8985: " HyeongJun An
2026-10-14 9:41 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 07/13] ASoC: codecs: wm8994: Fix definition of WM8958 noise gate hold time controls HyeongJun An
2026-10-14 9:46 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 08/13] ASoC: codecs: wm8955: Fix definition of Treble Cutoff control HyeongJun An
2026-10-14 9:51 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 09/13] ASoC: codecs: wm_hubs: Fix definition of MIXINR to MIXOUTR volume control HyeongJun An
2026-10-14 9:56 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 10/13] ASoC: codecs: wm8737: Fix definition of zero cross switches HyeongJun An
2026-10-14 9:58 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 11/13] ASoC: codecs: wm5100: Fix definition of EQ3 Band 1 Volume control HyeongJun An
2026-10-14 9:59 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 12/13] ASoC: codecs: wm8750: Fix definition of ALC Capture NG Type control HyeongJun An
2026-10-14 10:01 ` Charles Keepax
2026-10-14 6:32 ` [PATCH 13/13] ASoC: codecs: wm8510: Fix definition of ADC Inversion Switch control HyeongJun An
2026-10-14 10:04 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as9M3j6wBu5ZT2Ck@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=sammiee5311@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox