From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "Alvin Šipraga" <alvin.sipraga@analog.com>, linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 07/13] ASoC: soc-component: move soc_{probe/remove}_component() to soc-component.c
Date: Sun, 4 Oct 2026 23:52:40 +0200 [thread overview]
Message-ID: <asLKqMzZpRhloNXq@sirena.org.uk> (raw)
In-Reply-To: <87cxts6cha.wl-kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]
On Fri, Oct 02, 2026 at 02:52:01AM +0000, Kuninori Morimoto wrote:
> struct snd_soc_component will be capsuled soon, its member will not be
> able to access from non soc-component.c.
>
> Move soc_{probe/remove}_component() to soc-component.c
> -int snd_soc_component_probe(struct snd_soc_component *component)
> -{
> - int ret = 0;
> -
> - if (component->driver->probe)
> - ret = component->driver->probe(component);
> -
> - return soc_component_ret(component, ret);
This has a soc_component_ret()...
> +int snd_soc_component_probe(struct snd_soc_component *component, struct snd_soc_card *card)
> +{
> + if (component->card) {
> + if (component->card != card) {
> + dev_err(component->dev,
> + "Trying to bind component \"%s\" to card \"%s\" "
> + "but is already bound to card \"%s\"\n",
> + component->name, card->name, component->card->name);
Just have a long line - it's better not to split error messages to help
grep.
> + if (component->driver->probe) {
> + ret = component->driver->probe(component);
> + if (ret < 0)
> + goto err_probe;
> + }
...this doesn't have an equivalent error log to what soc_component_ret()
does which is probably not great for diagnostics, nor does the cleanup.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-04 21:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 2:50 [PATCH v2 00/13] ASoC: soc-component: move snd_soc_component_xxx() to soc-component.c Kuninori Morimoto
2026-10-02 2:51 ` [PATCH v2 01/13] ASoC: soc-component: tidyup be_hw_params_fixup() define position Kuninori Morimoto
2026-10-02 2:51 ` [PATCH v2 02/13] ASoC: soc-component: replace bool member to bit field Kuninori Morimoto
2026-10-02 2:51 ` [PATCH v2 03/13] ASoC: soc-component: move snd_soc_add_component_controls() Kuninori Morimoto
2026-10-02 2:51 ` [PATCH v2 04/13] ASoC: soc-component: move snd_soc_component_fixup_controls() Kuninori Morimoto
2026-10-02 2:51 ` [PATCH v2 05/13] ASoC: soc-component: move soc_component_to_node() to soc-component.c Kuninori Morimoto
2026-10-02 2:51 ` [PATCH v2 06/13] ASoC: soc-component: move snd_soc_is_matching_component() " Kuninori Morimoto
2026-10-02 2:52 ` [PATCH v2 07/13] ASoC: soc-component: move soc_{probe/remove}_component() " Kuninori Morimoto
2026-10-04 21:52 ` Mark Brown [this message]
2026-10-02 2:52 ` [PATCH v2 08/13] ASoC: soc-component: move snd_soc_component_to_dapm() " Kuninori Morimoto
2026-10-02 2:52 ` [PATCH v2 09/13] ASoC: soc-component: move snd_soc_component_cache_sync() " Kuninori Morimoto
2026-10-02 2:52 ` [PATCH v2 10/13] ASoC: soc-component: move snd_soc_component_active() " Kuninori Morimoto
2026-10-02 2:52 ` [PATCH v2 11/13] ASoC: soc-component: move component_list " Kuninori Morimoto
2026-10-02 2:52 ` [PATCH v2 12/13] ASoC: soc-component: move snd_soc_lookup_component() " Kuninori Morimoto
2026-10-02 2:52 ` [PATCH v2 13/13] ASoC: soc-component: rename snd_soc_component_async_complete() Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asLKqMzZpRhloNXq@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alvin.sipraga@analog.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox