From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58EFE318146 for ; Fri, 9 Oct 2026 01:50:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791510646; cv=none; b=SE4a2J7l3gMU2OIC+jHF/U+hGEa74omPzBM1YQoMLYQ4niR68PBXqrd/5ek5ld/qjqiK6H1xwd7DBpnsfhnSJ9SUAc7sTMPDP7iFr86ojihHfPxcankBm/PGiui2weRPvqPwrUjcWlMoteChSeVOPe57PrmY1aU6PxisNNl0Ypc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791510646; c=relaxed/simple; bh=bzyXo88bbpqY6OVmCc6w30E/dMqXq6juRHJb1N+nFEI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rVJhFTfEhAg4cbsF+bl1VIR+u/PwDet9dx/5LAcsL6Y2Xo9/K9DZ1UO9ppY1YTg64iE1l3ro37U9ya8racxFTgtki5JecWPr3PZ/SWCabS/Ii088a6SjyiR8/UGrzoIHu9nYU3wSSVYttTjm3MOy91RsidmqvBhgx+ny+gq/0dI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mDikJI8G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gh8Ei2Nd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mDikJI8G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gh8Ei2Nd" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6990PiJd2959152 for ; Fri, 9 Oct 2026 01:50:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Zgph80WKQsUMtMvcVbFtnTyy 4Q4vF5zHhNaoDpXMoq4=; b=mDikJI8GxcLLKgxXBKKWu8cDydPp3g9muiOhAy7n 6j2g/HzdKW9MpFjmAm4N6RtwhaVpSxwV+u4ixXxdmEr8wS/HjcyFiplMGY57oImm 1Df2Y5nvIsUSMXKTw0IQpnlC8KQiUppSxx9/HBmhHj3aqlPB3Yr7liNa5C6Q2qQk MHSm295wVijXkXbXpWtZYkhpK+HVgogAj5Eh5RKr4Lvy6ZL1Xe4ZcabsddIK13V8 VokyfqkNkZip2gCpTbv9+Jzie7OuyxCEYKR3evXc8JuBNqY5Wfa398yjAE2ZfS4M Sx5NGA5jOiErD+AQfIV6OZwsD6qYyweSoHk+sKYznLLAdw== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h6ev59nn9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Oct 2026 01:50:44 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-34d62bb27a1so2318673eec.0 for ; Thu, 08 Oct 2026 18:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791510644; x=1792115444; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Zgph80WKQsUMtMvcVbFtnTyy4Q4vF5zHhNaoDpXMoq4=; b=Gh8Ei2NdkHbL75p12EPxrTxD+4Yea+bX8I99kSvkW/3FEq1u+bOcMWqMt1fBlwzxp4 93+jcvR86MHGsPgXyyghPnToTc19fXVYkpKai5aYgnbz3Z6pIJqA32f3q5yfD8W1YWOv 2ixJipETLP6DOhk3zqatlan++K1N5QnT2lzWaJOyoymnNNKyAYYSclhB3Q69H1WD3XNU gxckb/uOkJs9MVRlS+aNzAcXpvpcGQ+f5NPaZ42yHRjTICTT5GIX34TSO4+jZll4acL4 3pxfT7/G/EHLJY9L/T6GilkbRpteseektledOCyh4eRDN3T6vJxUDAT15zmc1IFqyKyH opeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791510644; x=1792115444; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Zgph80WKQsUMtMvcVbFtnTyy4Q4vF5zHhNaoDpXMoq4=; b=TpuiS3ptxUCllm1NNaxMGAfvCvJEGEDfqBkQ2W1d7icAJlrJSOjGHKGk2w+wv532Om xAzAp830RovJEd1/MZ1xmPvwC9CciWM6Q64guKnhZbJ4ApgJuw+WX0wQKeIdWLEwURI2 /Hk0b9Wofe/nr0cdUtjdT6CjpE31YPKtdTY0riRSqtzAI9vjKpwVUsdFN4ARnW++uziD LWms81fMq322dNHTCE14YvLIFjWqHY/dmB31zcAwzrImLyf+iThJyM3VojcrP1Gf+Kla KivIusTINsakgHG4eu4WsZANztxqZdYl+9cmBrkxJR9Y3or120NpTRni1xfhb0mB5RbB s+GQ== X-Forwarded-Encrypted: i=1; AKwUvBzD9F0/itAqirW2+e72OIqbkO7WEJ/VEX+ozHz95L8dRS1n8GOBa4fSrtppRSff2vEYD0NnYPYQzpXDhA==@vger.kernel.org X-Gm-Message-State: AFq9FYJRVOEcG1NIf6B01jiA4v+PgN+JFAVW8/kH95otF4UWwP+Na4Jz lCfMNr6mo3HF8Jr66tXep7BYRMhJVaRmWro2fwVVAuIcuQ54+Ch4SzniHocCEI1ISk+Owh/BWaZ EoJkiLsD1pQgG+4/s1+geqbmueoVF8tp0CuinWCA+p4L1UeDRIbA1apMHbu44VmBKYQ== X-Gm-Gg: AYBFou1OpcdKaPsdICxEEwJLwe2vFJ/PSwv2Zg3NvJB6AX0xpGrJ/Mbq6ryCo8tlWQS /Adn2Zd8EfuD9sP4/iR1qTsv6Nl0ayP6UuYjjvGOWsj+PH746aQJ+s0ejkA7PLwhGR4P3Re4FIa izLE9bnY8JZtCNL1epKeR1jM9xbWQQPBmoDtVXNvSkKgqZnqsWmrbJ1qVEnz0C8lGUhRYIgNSIy jXKAqHiu+CqQ0Wx7YbNICrg78wOmZjU+TkCFL+nQfvj9g16kX1WyOCUbs3ayEoK73wE3ySag9e+ uSETMTEmup+1+D16Srewt2fNQFpvOpcIQqtHFtLbDgS1uscL4mFIIr692cQ6vnBwnmnhJ7ha8O1 MmUp3Yb6sGpV5oeoOxaOMRSZsxCvwFw/qvPTU+YYH9A== X-Received: by 2002:a05:7300:81:b0:353:81a3:9032 with SMTP id 5a478bee46e88-35381a391eamr216569eec.39.1791510643701; Thu, 08 Oct 2026 18:50:43 -0700 (PDT) X-Received: by 2002:a05:7300:81:b0:353:81a3:9032 with SMTP id 5a478bee46e88-35381a391eamr216532eec.39.1791510643172; Thu, 08 Oct 2026 18:50:43 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3537cb2954bsm1964083eec.26.2026.10.08.18.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 18:50:42 -0700 (PDT) Date: Fri, 9 Oct 2026 09:50:36 +0800 From: Shawn Guo To: Mohammad Rafi Shaik Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 0/5] ASoC: qcom: Add Nord audio support Message-ID: References: <20261008-nord-asoc-driver-support-v2-v2-0-0b6f7e94060d@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261008-nord-asoc-driver-support-v2-v2-0-0b6f7e94060d@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA5MDAwNyBTYWx0ZWRfX94+u99mQepty oCLdzAuleOW1Wxzcy2DSyE7Gmfy86erkVP0G5PhcLqBuV6r7wokBAHTFkhQoDQKgpGKWXnOQDFN nMIGTy38Jjj9aCpmQHzSfXAI/67Q7ns= X-Authority-Analysis: v=2.4 cv=MMT1C8Zl c=1 sm=1 tr=0 ts=6ac84874 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=PeLITbGe0R9p4Ny4VdEA:9 a=CjuIK1q_8ugA:10 a=bBxd6f-gb0O0v-kibOvt:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-GUID: yE7QNeyHlToohAMvy5OeGjXpAXLWYiub X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA5MDAwNyBTYWx0ZWRfX4Dju235xUhYA 7aJEtkjywwuIxzxG1fH7rBc+NO/UspxkY+2G1tg1+174I+V5rY3xw6GBjc7Cz216BNAtqwao5KI E0oLGiaovm+JCWez+8Bi0OOyeeMvOx+YoBSoACiLRPTTeNZcqFmcOafouM2Qesrz5rcy3JdZJBy GNQtViKBbmrIcOoBJKlCSA57lbD1UsPOsolE2Z7sgJ1rMB6InHpGSkfCK+e+XXpPeFjLFEeAjZu /8iJjO5sk3tEQhgP2Gl14xOfjuDcw7VVdEvJ7rNJGBQWyUpkJ5GjbBKzLAZL9KPlqqXZUvNWITm b1mlWRWDnguzwTMkY41K0Az5pdQ1EnIorMi+LOmYk5HX0FJlH8f4wDJGZSkrFXsCcpfSTPwO/Sz jmFEejgmI2wldU9FzEhnBVdlpU3C2qngOgNTFDIG5ucJ9TNVnuzIEywnxyFOvr/ZRshgwF1pKHv 2l4q5XB1uWb2BJMTe8g== X-Proofpoint-ORIG-GUID: yE7QNeyHlToohAMvy5OeGjXpAXLWYiub X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-09_01,2026-10-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610090007 On Thu, Oct 08, 2026 at 04:36:40PM +0530, Mohammad Rafi Shaik wrote: > This series adds audio support for the Qualcomm Nord Ride and > RRD boards and includes the required machine driver, device tree > binding updates, and codec improvements needed for the board's > external audio codec configuration. > > Nord Ride uses a PCM1681 DAC for playback and an ADAU1979 ADC for capture. > Compared to other SC8280XP based platforms, Nord Ride requires > board-specific DAI format and codec clock configuration to support > the external PCM1681 DAC and ADAU1979 ADC. > > Signed-off-by: Mohammad Rafi Shaik > --- > Changes in v2: > - Dropped patch 1 from v1, as the ADAU1979 codec change has already been applied. > - Moved the compatible string from the board-specific file to the SoC file, as suggested by Shawn. > - Added runtime PM support to the PCM1681 codec to manage the SCK clock sequence. > - Added TDM support to the PCM1681 codec. > - Added the required POR delay to the PCM1681 codec, as suggested by Mark Brown. > - Replaced LPASS DAI IDs with QAIF DAI IDs. > - Link to v1: https://patch.msgid.link/20260907-nord-asoc-driver-support-v1-0-997d3b20cf43@oss.qualcomm.com I expect some PCM1681 driver changes in v2 to address Konrad's comment [1]. Or do I miss something? Shawn [1] https://lore.kernel.org/all/d2d2feff-4823-43dc-9014-099e69195280@oss.qualcomm.com/