From: Sasha Levin <sashal@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Daniel Baluta <daniel.baluta@nxp.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
sound-open-firmware@alsa-project.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: SOF: Intel: hda: Stop the controller before freeing its DMA buffers
Date: Sun, 1 Nov 2026 19:32:22 -0500 [thread overview]
Message-ID: <aufaFu3THHiUf_t3@laps> (raw)
In-Reply-To: <179357405490.1679716.7958054921741157139.b4-review@b4>
On Sun, Nov 01, 2026 at 11:00:54PM +0000, Mark Brown wrote:
>> hda_dsp_probe() starts the CORB/RIRB DMA engines through
>> hda_dsp_ctrl_init_chip(), but neither hda_dsp_remove() nor the error
>> path of hda_dsp_probe() stops them before hda_dsp_stream_free() frees
>> the CORB/RIRB ring buffer and the position buffer. Unsolicited
>> responses also stay enabled, so the controller can keep writing RIRB
>> entries into the freed page.
>
>This doesn't apply against current code, please check and resend.
Just to confirm, I see this in Linus's tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=11ae63bd9030349a0136fb2edd1622a4a029edc8 .
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-11-02 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 14:44 [PATCH] ASoC: SOF: Intel: hda: Stop the controller before freeing its DMA buffers Sasha Levin
2026-10-29 7:46 ` Péter Ujfalusi
2026-10-29 9:20 ` Li, Yifan2
2026-10-29 11:41 ` Mark Brown
2026-11-01 23:00 ` Mark Brown
2026-11-02 0:32 ` Sasha Levin [this message]
2026-11-02 0:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aufaFu3THHiUf_t3@laps \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox