Re: [PATCH v2 08/27] ASoC: soc-generic-dmaengine-pcm: use snd_soc_component_unregister()

["Alvin Šipraga" <alvin.sipraga@analog.com>]

On Thu, Nov 12, 2026 at 12:32:23AM +0000, Kuninori Morimoto wrote:
> Current snd_dmaengine_pcm_unregister() (X) is using
> snd_soc_unregister_component_by_driver() (Y) to unregister component.
> 
> (X)	void snd_dmaengine_pcm_unregister(...)
> 	{
> (Z)		component = snd_soc_lookup_component(...);
> 		...
> (p)		pcm = snd_soc_component_to_priv(component);
> 
> (Y)		snd_soc_unregister_component_by_driver(...);
> (p)		dmaengine_pcm_release_chan(pcm);
> (p)		kfree(pcm);
> 	}
> 
> But it try to unregister all components from dev (a).
> 
> (Y)	void snd_soc_unregister_component(...)
> 	{
> 		...
> 		while (1) {
> (Z)			component = snd_soc_lookup_component_nolocked(...);
> 			...
> (a)			snd_soc_component_unregister(component);
> 		}
> 	}
> 
> snd_dmaengine_pcm_unregister() (X) need to care/free pcm which is connected
> to component (= p). Both (X) and (Y) are using lookup_component (Z).
> So (X) can handle first component/pcm (p), but can't handle 2nd or more
> component/pcm eventhough (X) was called multiple times, because (Y)
> unregister all components. Let's call snd_soc_component_unregister() (a)
> instead of snd_soc_unregister_component_by_driver() (Y) in (X), and
> unregister target component only, not all.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/r/sashiko-outbox-206296@kernel.org

Reviewed-by: Alvin Šipraga <alvin.sipraga@analog.com>

> ---
>  sound/soc/soc-generic-dmaengine-pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)