Re: [PATCH 2/2] ASoC: cs42l43: Update load detect procedure for cs42l43b

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Wed, Nov 11, 2026 at 05:47:46PM +0000, sashiko-bot@kernel.org wrote:
> > +		switch (type) {
> > +		case CS42L43_TYPE_OMTP:
> > +			regmap_write(cs42l43->regmap, CS42L43B_LOAD_DET_SEL, 0x89);
> > +			break;
> > +		default:
> > +			regmap_write(cs42l43->regmap, CS42L43B_LOAD_DET_SEL, 0x98);
> > +			break;
> > +		}
> > +		break;
> > +	}
> 
> [Severity: Medium]
> Does writing CS42L43B_LOAD_DET_SEL via regmap_write() here and in
> cs42l43_stop_load_detect() cache the register in REGCACHE_MAPLE and cause
> every subsequent regcache_sync() in cs42l43_runtime_resume() to re-write
> it to hardware?

Yeah the register should be marked as readable missed the fact
that overrides precious. Will spin for this.

> > -	switch (type & CS42L43_HSDET_TYPE_STS_MASK) {
> > -	case 0x0: // CTIA
> > -	case 0x1: // OMTP
> > -	case 0x4:
> > -		return cs42l43_run_load_detect(priv, true);
> > -	case 0x2: // 3-pole
> > -		return cs42l43_run_load_detect(priv, false);
> > -	case 0x3: // Open-circuit
> > +	type &= CS42L43_HSDET_TYPE_STS_MASK;
> > +
> > +	if (type == CS42L43_TYPE_OPEN)
> >  		return CS42L43_JACK_EXTENSION;
> > -	default:
> > -		return -EINVAL;
> > -	}
> > +	else
> > +		return cs42l43_run_load_detect(priv, type);
> >  }
> 
> [Severity: Medium]
> Does replacing the switch in cs42l43_run_type_detect() cause invalid
> CS42L43_HS_STAT values (0x5..0x7) to be misclassified as a 4-pole headset
> instead of returning -EINVAL?
> 
> In cs42l43_run_type_detect(), type is initialized to 0xff and
> regmap_read(cs42l43->regmap, CS42L43_HS_STAT, &type) is not checked for
> errors; if that read fails or hardware reports 0x5..0x7, type &
> CS42L43_HSDET_TYPE_STS_MASK is passed to cs42l43_run_load_detect(), which
> now hits the default branch, enables headset bias and button detection,
> and reports CS42L43_JACK_HEADSET.  In addition, the CS42L43_TYPE_OPEN
> cases in cs42l43_start_load_detect() and cs42l43_run_load_detect() are
> unreachable because cs42l43_run_type_detect() returns
> CS42L43_JACK_EXTENSION when type == CS42L43_TYPE_OPEN.

I think we are happy with these, failing the headset detect is
not super useful. And it is safer to handle the open cases
even if at the moment we can't hit those in load detect, load
detect has historically been uses a couple of times to try and
detect what is/when something is connected to an extension cable,
so probably safer against future refactoring.

Thanks,
Charles