Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Rafael Diniz <rafael@riseup.net>
Cc: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	patches@opensource.cirrus.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: wm8731: power the converters together, activate the interface last
Date: Fri, 20 Nov 2026 10:19:36 +0000	[thread overview]
Message-ID: <awAeuPsyk0iKu1wk@opensource.cirrus.com> (raw)
In-Reply-To: <awAc35H1iSr7fk5Z@opensource.cirrus.com>

On Fri, Nov 20, 2026 at 10:11:43AM +0000, Charles Keepax wrote:
> On Fri, Nov 20, 2026 at 08:07:55AM +0000, Rafael Diniz wrote:
> Would it be slightly neater to use an OUT_DRV widget instead?
> The wm8731 doesn't have any of the widgets that run after it (nor
> is it likely to acquire any) and it would allow for a slightly
> more symmetrical handling of the ACTIVE bit rather than splitting
> it across two widgets.

Ah nuggets, missed that ADC widgets are weirdly powered down
before OUT_DRVs. Let me rethink that.

Thanks,
Charles

      reply	other threads:[~2026-11-20 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  8:07 [PATCH v2] ASoC: wm8731: power the converters together, activate the interface last Rafael Diniz
2026-11-20  8:25 ` sashiko-bot
2026-11-20 10:11 ` Charles Keepax
2026-11-20 10:19   ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awAeuPsyk0iKu1wk@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rafael@riseup.net \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox