From: "Liao, Bard" <yung-chuan.liao@linux.intel.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>, broonie@kernel.org
Cc: lgirdwood@gmail.com, vkoul@kernel.org,
pierre-louis.bossart@linux.dev, peter.ujfalusi@linux.intel.com,
shumingf@realtek.com, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 0/3] SDCA Jack Fixups
Date: Fri, 19 Dec 2025 09:58:13 +0800 [thread overview]
Message-ID: <b2483cc9-d549-4c59-baa1-8dba8ebd6804@linux.intel.com> (raw)
In-Reply-To: <20251215153650.3913117-1-ckeepax@opensource.cirrus.com>
On 12/15/2025 11:36 PM, Charles Keepax wrote:
> Some fixups to the jack handling, adding some necessary hooks to connect
> things with the machine driver. I have split these out from the system
> suspend chain as that has been generating a fair amount of discussion
> and getting these 3 merged is far more important to get basic
> functionality working smoothly. I will do a spin of the system suspend
> stuff soon, if either no new comments pop up, or we reach some consensus
> on how to proceed.
>
> Thanks,
> Charles
Looks good to me.
For the series:
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>
> Charles Keepax (3):
> ASoC: SDCA: Factor out jack handling into new c file
> ASoC: SDCA: Add ability to connect SDCA jacks to ASoC jacks
> ASoC: SDCA: Add ASoC jack hookup in class driver
>
> include/sound/sdca_jack.h | 32 ++++
> sound/soc/sdca/Makefile | 2 +-
> sound/soc/sdca/sdca_class_function.c | 13 ++
> sound/soc/sdca/sdca_interrupts.c | 83 +--------
> sound/soc/sdca/sdca_jack.c | 244 +++++++++++++++++++++++++++
> 5 files changed, 297 insertions(+), 77 deletions(-)
> create mode 100644 include/sound/sdca_jack.h
> create mode 100644 sound/soc/sdca/sdca_jack.c
>
next prev parent reply other threads:[~2025-12-19 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 15:36 [PATCH 0/3] SDCA Jack Fixups Charles Keepax
2025-12-15 15:36 ` [PATCH RESEND 1/3] ASoC: SDCA: Factor out jack handling into new c file Charles Keepax
2025-12-15 15:36 ` [PATCH RESEND 2/3] ASoC: SDCA: Add ability to connect SDCA jacks to ASoC jacks Charles Keepax
2025-12-15 15:36 ` [PATCH RESEND 3/3] ASoC: SDCA: Add ASoC jack hookup in class driver Charles Keepax
2025-12-19 1:58 ` Liao, Bard [this message]
2025-12-22 20:58 ` [PATCH 0/3] SDCA Jack Fixups Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2483cc9-d549-4c59-baa1-8dba8ebd6804@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=shumingf@realtek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox