From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 255F52D63E5; Mon, 1 Dec 2025 11:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764589259; cv=none; b=HZBGcx7/0EIG1XzLcGi9nEk2ohFN2FV0zvmDhDznW2BukNSJN3QLRzwynxQSxjgEJIwrJ0u1VeQk/Tswm7o+4sKxR+GoSsBEaU+UR9TNnu3z+tzhgqsozCT+UBfenKGwXJfZ4ZZEoU+8hC+U+yeH9Pluni5y/dMubjtkAFbblBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764589259; c=relaxed/simple; bh=n/7SGc08cPocf6f8xgtz+bfuQlqpXueIfuFBLsyH6EM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DAH/Z0KrxS8zmo6zZ5Lz4/0QoepxhjyycHuMJqbrPkuxPw6IBVqIL42Gzgo8RruOcKjgtgY4s3AKg6lFUlwfU/Z4bIjmz0YFPT66cHWP2i8KW/FXhKI60I5Kw/sq5imqkvf5LVBDOXP7Gz7U11VTQKCUi6kly6qO883/rjk2PsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hFCSBjY0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hFCSBjY0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE0E6C113D0; Mon, 1 Dec 2025 11:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764589259; bh=n/7SGc08cPocf6f8xgtz+bfuQlqpXueIfuFBLsyH6EM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hFCSBjY0k9NyweXuHub0kXHkmEH446SUfblRuwI4MXAduCVBj6KxC5GKpS69UObX6 aYaCd8XMjS8TBmNmmuDQsWtC6Yz7AE529G31rXhN/KM98MvEeFbgm3TwMUIpu3WGFz 9miM/VCFeZOmfoWjN4MSMGPASAg1iBpO/boyQG1PCpSHoFNvtzutOVH4CmwIVNPCfJ dFm5ygdBg0N7ZB6hkzewE4KFJGHKna8kRaghqgo21xtky5i34NEKuLBgjKNj3YP/ro fsqSaOnO2sztOp7yzd0X48ILubQp3mIGnY+2gCyf0NlEslQEVlr7Z6v5nG49tPHAP1 enmaTV+TfK/kQ== Message-ID: Date: Mon, 1 Dec 2025 12:40:55 +0100 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: cs-amp-lib: Use __free(kfree) instead of manual freeing To: Richard Fitzgerald Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Mark Brown References: <20251127155817.1374079-1-rf@opensource.cirrus.com> <8f889b72-479c-46fb-a8cf-c9abfc491463@kernel.org> <8f6f1dc9-8b14-442c-8999-934ac312a1bd@opensource.cirrus.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 01/12/2025 12:30, Richard Fitzgerald wrote: > On 01/12/2025 9:57 am, Richard Fitzgerald wrote: >> On 29/11/2025 2:28 pm, Krzysztof Kozlowski wrote: >>> On 27/11/2025 16:58, Richard Fitzgerald wrote: >>>> Use the __free(kfree) cleanup to replace instances of manually >>>> calling kfree(). Also make some code path simplifications that this >>>> allows. >>>> >>>> Signed-off-by: Richard Fitzgerald >>>> --- >>>>   sound/soc/codecs/cs-amp-lib.c | 29 ++++++++++++----------------- >>>>   1 file changed, 12 insertions(+), 17 deletions(-) >>>> >>>> diff --git a/sound/soc/codecs/cs-amp-lib.c b/sound/soc/codecs/cs-amp- >>>> lib.c >>>> index d8f8b0259cd1..8c9fd9980a7d 100644 >>>> --- a/sound/soc/codecs/cs-amp-lib.c >>>> +++ b/sound/soc/codecs/cs-amp-lib.c >>>> @@ -7,6 +7,7 @@ >>>>   #include >>>>   #include >>>> +#include >>>>   #include >>>>   #include >>>>   #include >>>> @@ -309,9 +310,8 @@ static struct cirrus_amp_efi_data >>>> *cs_amp_get_cal_efi_buffer(struct device *dev, >>>>                                    efi_guid_t **guid, >>>>                                    u32 *attr) >>>>   { >>>> -    struct cirrus_amp_efi_data *efi_data; >>>> +    struct cirrus_amp_efi_data *efi_data __free(kfree) = NULL; >>> >>> This is an undesired syntax explicitly documented as one to avoid. You >>> need here proper assignment, not NULL. Please don't use cleanup.h if you >>> do not intend to follow it because it does not make the code simpler. >>> >> >> LOL >> The new system to improve cleanup introduces new cleanup bugs. :) >> >>> >>> Best regards, >>> Krzysztof >> > I found 119 other instances of this _free(kfree) something = NULL; idiom > in sound/ and ~300 across the whole kernel. So you've got quite some > code to fix. In few cases, when allocation is within some if() block, this is a correct approach but most likely 90% of these 300 are same cases of not following cleanup.h. And then also mixing it up with gotos (another explicitly documented rule which people ignore). Best regards, Krzysztof