public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Zhang Yi <zhangyi@everest-semi.com>,
	broonie@kernel.org, tiwai@suse.com, linux-sound@vger.kernel.org
Cc: peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
	ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com
Subject: Re: [PATCH v4 5/6] ASoC: Intel: soc-acpi: arl: Add es9356 support
Date: Tue, 31 Mar 2026 16:48:16 +0200	[thread overview]
Message-ID: <b44fd63b-3052-4333-8c2b-3d6056d6fef4@linux.dev> (raw)
In-Reply-To: <20260327095954.3465-6-zhangyi@everest-semi.com>


> +static const struct snd_soc_acpi_link_adr arl_n_mrd_es9356_link0[] = {
> +	{
> +		.mask = BIT(1),

link0 uses BIT(1)?

One of the two is incorrect, which is it?

> +		.num_adr = ARRAY_SIZE(es9356_adr),
> +		.adr_d = es9356_adr,
> +	},
> +	{}
> +};

  reply	other threads:[~2026-03-31 14:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27  9:59 [PATCH v4 0/6] Add es9356 focused SoundWire CODEC Zhang Yi
2026-03-27  9:59 ` [PATCH v4 1/6] ASoC: sdw_utils: Add ES9356 support functions Zhang Yi
2026-03-31 12:28   ` Pierre-Louis Bossart
2026-03-27  9:59 ` [PATCH v4 2/6] ASoC: sdw_utils: add ES9356 in codec_info_list Zhang Yi
2026-03-31 12:27   ` Pierre-Louis Bossart
2026-03-27  9:59 ` [PATCH v4 3/6] ASoC: sdw_utils: add soc_sdw_es9356 Zhang Yi
2026-03-31 14:42   ` Pierre-Louis Bossart
2026-03-27  9:59 ` [PATCH v4 4/6] ASoC: es9356-sdca: Add ES9356 SDCA driver Zhang Yi
2026-03-27 13:24   ` Charles Keepax
2026-03-31 14:46   ` Pierre-Louis Bossart
2026-03-27  9:59 ` [PATCH v4 5/6] ASoC: Intel: soc-acpi: arl: Add es9356 support Zhang Yi
2026-03-31 14:48   ` Pierre-Louis Bossart [this message]
2026-03-27  9:59 ` [PATCH v4 6/6] ASoC: Intel: sof_sdw: add " Zhang Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b44fd63b-3052-4333-8c2b-3d6056d6fef4@linux.dev \
    --to=pierre-louis.bossart@linux.dev \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    --cc=zhangyi@everest-semi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox