Re: [PATCH v4 1/6] ASoC: sdw_utils: Add ES9356 support functions

Pierre-Louis Bossart
2026-03-31T14:50:17Z

On 3/27/26 10:59, Zhang Yi wrote:
> Add the functions into the machine driver for the es9356
>
> Signed-off-by: Zhang Yi <zhangyi@everest-semi.com>

not sure I see the benefits of having a patch that only adds the prototypes, maybe squash with patch 3?

> ---
> include/sound/soc_sdw_utils.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/include/sound/soc_sdw_utils.h b/include/sound/soc_sdw_utils.h
> index 98531e500..c18f5016d 100644
> --- a/include/sound/soc_sdw_utils.h
> +++ b/include/sound/soc_sdw_utils.h
> @@ -220,6 +220,17 @@ int asoc_sdw_cs42l43_spk_init(struct snd_soc_card *card,
> struct asoc_sdw_codec_info *info,
> bool playback);
>
> +/* es9356 codec support */
> +int asoc_sdw_es9356_init(struct snd_soc_card *card,
> + struct snd_soc_dai_link *dai_links,
> + struct asoc_sdw_codec_info *info,
> + bool playback);
> +int asoc_sdw_es9356_amp_init(struct snd_soc_card *card,
> + struct snd_soc_dai_link *dai_links,
> + struct asoc_sdw_codec_info *info,
> + bool playback);
> +int asoc_sdw_es9356_exit(struct snd_soc_card *card, struct snd_soc_dai_link *dai_link);
> +
> /* CS AMP support */
> int asoc_sdw_bridge_cs35l56_count_sidecar(struct snd_soc_card *card,
> int *num_dais, int *num_devs);
> @@ -271,5 +282,8 @@ int asoc_sdw_ti_amp_init(struct snd_soc_card *card,
> int asoc_sdw_ti_spk_rtd_init(struct snd_soc_pcm_runtime *rtd, struct snd_soc_dai *dai);
> int asoc_sdw_ti_amp_initial_settings(struct snd_soc_card *card,
> const char *name_prefix);
> +int asoc_sdw_es9356_rtd_init(struct snd_soc_pcm_runtime *rtd, struct snd_soc_dai *dai);
> +int asoc_sdw_es9356_spk_rtd_init(struct snd_soc_pcm_runtime *rtd, struct snd_soc_dai *dai);
> +int asoc_sdw_es9356_dmic_rtd_init(struct snd_soc_pcm_runtime *rtd, struct snd_soc_dai *dai);
>
> #endif