Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Dirk Su <dirk.su@canonical.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Lane Odenbach <laodenbach@gmail.com>,
	Oliver Schramm <oliver.schramm97@gmail.com>,
	Adam Queler <queler@gmail.com>,
	Gabriel Santese <santesegabriel@gmail.com>,
	Raven Black <ravenblack@gmail.com>,
	Radhi Bajahaw <bajahawradhi@gmail.com>,
	Alexandru Andries <alex.andries.aa@gmail.com>,
	Talhah Peerbhai <talhah.peerbhai@gmail.com>,
	meowmeowbeanz <meowmeowbeanz@gmx.com>,
	Yuzuru10 <yuzuru_10@proton.me>, keenplify <keenplify@gmail.com>,
	Syed Saba kareem <syed.sabakareem@amd.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: amd: yc: Add quirk for HP 200 G2a 16
Date: Thu, 29 Jan 2026 13:36:27 -0600	[thread overview]
Message-ID: <b4b2c531-7e9c-422e-b825-e34519e0afad@amd.com> (raw)
In-Reply-To: <20260129065038.39349-1-dirk.su@canonical.com>

On 1/29/26 12:50 AM, Dirk Su wrote:
> Fix the missing mic on HP 200 G2a 16 by adding quirk with the
> board ID 8EE4
> 
> Signed-off-by: Dirk Su <dirk.su@canonical.com>

Is this a production hardware and firmware?

If so this patch makes sense.

If it's not, can you please explore adding the _DSD entry 
"AcpDmicConnected".

> ---
>   sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 0294177acc663..500b4fda0581f 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -633,6 +633,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>   			DMI_MATCH(DMI_BOARD_NAME, "8BD6"),
>   		}
>   	},
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> +			DMI_MATCH(DMI_BOARD_NAME, "8EE4"),
> +		}
> +	},
>   	{
>   		.driver_data = &acp6x_card,
>   		.matches = {


  reply	other threads:[~2026-01-29 19:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29  6:50 [PATCH] ASoC: amd: yc: Add quirk for HP 200 G2a 16 Dirk Su
2026-01-29 19:36 ` Mario Limonciello [this message]
     [not found]   ` <CANJZD57huXXBuUiq=nJZ_WmucCkFv4vKHLUdXSmTvokjTadz6Q@mail.gmail.com>
2026-01-30 14:37     ` Mario Limonciello
2026-02-03 12:05 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4b2c531-7e9c-422e-b825-e34519e0afad@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=alex.andries.aa@gmail.com \
    --cc=bajahawradhi@gmail.com \
    --cc=broonie@kernel.org \
    --cc=dirk.su@canonical.com \
    --cc=keenplify@gmail.com \
    --cc=laodenbach@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=meowmeowbeanz@gmx.com \
    --cc=oliver.schramm97@gmail.com \
    --cc=perex@perex.cz \
    --cc=queler@gmail.com \
    --cc=ravenblack@gmail.com \
    --cc=santesegabriel@gmail.com \
    --cc=syed.sabakareem@amd.com \
    --cc=talhah.peerbhai@gmail.com \
    --cc=tiwai@suse.com \
    --cc=yuzuru_10@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox