Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Mingcong Bai <jeffbai@aosc.io>, broonie@kernel.org
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022
Date: Fri, 1 Nov 2024 11:11:50 -0500	[thread overview]
Message-ID: <b67ce3b2-dca4-483a-96f5-aeaee8deb5ec@amd.com> (raw)
In-Reply-To: <8bad41b7ddbc8e061f682ecdf00a50e1@aosc.io>

On 10/31/2024 23:35, Mingcong Bai wrote:
> Xiaomi Book Pro 14 2022 (MIA2210-AD) requires a quirk entry for its
> internal microphone to be enabled.
> 
> This is likely due to similar reasons as seen previously on Redmi Book
> 14/15 Pro 2022 models (since they likely came with similar firmware):
> 
> - dcff8b7ca92d724bdaf474a3fa37a7748377813a (ASoC: amd: yc: Add Xiaomi
>    Redmi Book Pro 15 2022 into DMI table)
> - c1dd6bf6199752890d8c59d895dd45094da51d1f (ASoC: amd: yc: Add Xiaomi
>    Redmi Book Pro 14 2022 into DMI table)
> 
> A quirk would likely be needed for Xiaomi Book Pro 15 2022 models, too.
> However, I do not have such device on hand so I will leave it for now.
> 
> Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
Yes makes sense this is a Rembrandt laptop.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 438865d5e376..dc476bfb6da4 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -395,6 +395,13 @@ static const struct dmi_system_id 
> yc_acp_quirk_table[] = {
>               DMI_MATCH(DMI_PRODUCT_NAME, "Redmi Book Pro 15 2022"),
>           }
>       },
> +    {
> +        .driver_data = &acp6x_card,
> +        .matches = {
> +            DMI_MATCH(DMI_BOARD_VENDOR, "TIMI"),
> +            DMI_MATCH(DMI_PRODUCT_NAME, "Xiaomi Book Pro 14 2022"),
> +        }
> +    },
>       {
>           .driver_data = &acp6x_card,
>           .matches = {


  reply	other threads:[~2024-11-01 16:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-01  4:35 [PATCH] ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022 Mingcong Bai
2024-11-01 16:11 ` Mario Limonciello [this message]
2024-11-05 19:11 ` Mark Brown
2024-11-06  2:43   ` Mingcong Bai
2024-11-06 20:40 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b67ce3b2-dca4-483a-96f5-aeaee8deb5ec@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=broonie@kernel.org \
    --cc=jeffbai@aosc.io \
    --cc=linux-sound@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox