From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: <tiwai@suse.com>, <broonie@kernel.org>, <perex@perex.cz>,
<amade@asmblr.net>, <linux-sound@vger.kernel.org>,
<kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v5] ALSA: control: Verify put() result when in debug mode
Date: Thu, 19 Feb 2026 18:05:56 +0100 [thread overview]
Message-ID: <b9f5071d-dc20-40df-847a-d8ff0ade2f5d@intel.com> (raw)
In-Reply-To: <87v7ftqb4d.wl-tiwai@suse.de>
On 2026-02-19 11:30 AM, Takashi Iwai wrote:
> On Thu, 19 Feb 2026 11:15:41 +0100,
> Cezary Rojewski wrote:
...
>> In regard to the "trace system", not a fan of adding a new "system"
>> just for the sake of a single event.
>
> Why not? We may extend the tracing of controls, too, and it'll make
> easier to enable all tracepoints relevant either for PCM or control.
>
>> If we are going that route, I'd
>> rather reword "snd_pcm" to "snd" or something similar. From sound-core
>> perspective, I believe there should be 1 directory for the events
>> declared in sound/core. The event-names are prefixed already, further
>> division looks redundant.
>
> That'll be messy under /sys/kernel/debug/tracing/events/*; it'll
> become snd/applptr, snd/hwptr, etc. So, if we want to consolidate
> into a single directory, we need to put "pcm_" prefix again to each.
>
> Or maybe better to use subdirectories "snd/pcm" and "snd/ctl" instead.
Well, I'm taking example from existing directories e.g.:
trace/events/power or trace/events/sched. TBH, trace/event/asoc fits
here too - all of them just group events together. sched_kthread_xxx are
in the same bucket as sched_process_xxx (as are plenty of others). The
'name' alone is enough of a filter. I believe that until one reaches
certain number of event-types, there is no reason to dilute the hierarchy.
However, looking at the subject from a high-level perspective, I think
it isn't in the scope of this patch - I can align to any suggested
pattern and we can work on the details in a dedicated series.
Kind regards,
Czakre
next prev parent reply other threads:[~2026-02-19 17:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 9:46 [PATCH v5] ALSA: control: Verify put() result when in debug mode Cezary Rojewski
2026-02-19 10:08 ` Takashi Iwai
2026-02-19 10:09 ` Takashi Iwai
2026-02-19 10:15 ` Cezary Rojewski
2026-02-19 10:30 ` Takashi Iwai
2026-02-19 17:05 ` Cezary Rojewski [this message]
2026-02-19 10:36 ` Jaroslav Kysela
2026-02-19 16:54 ` Cezary Rojewski
2026-02-24 13:17 ` Jaroslav Kysela
2026-02-24 15:34 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f5071d-dc20-40df-847a-d8ff0ade2f5d@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amade@asmblr.net \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox