public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: "Holalu Yogendra, Niranjan" <niranjan.hy@ti.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
	Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
	"ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
	"shumingf@realtek.com" <shumingf@realtek.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"ranjani.sridharan@linux.intel.com"
	<ranjani.sridharan@linux.intel.com>,
	"cezary.rojewski@intel.com" <cezary.rojewski@intel.com>,
	"peter.ujfalusi@linux.intel.com" <peter.ujfalusi@linux.intel.com>,
	"kai.vehmanen@linux.intel.com" <kai.vehmanen@linux.intel.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"Ding, Shenghao" <shenghao-ding@ti.com>,
	"Xu, Baojun" <baojun.xu@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Kasargod, Sandeep" <sandeepk@ti.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"yung-chuan.liao@linux.intel.com"
	<yung-chuan.liao@linux.intel.com>
Subject: Re: [PATCH v1 RESEND] SoundWire: Allow Prepare command for Simplified_CP_SM
Date: Sat, 14 Feb 2026 16:42:49 +0000	[thread overview]
Message-ID: <bc2fcd39b9f943a3b08c1af354ca6f09@ti.com> (raw)
In-Reply-To: <f3a7b462-477d-459b-91ba-1ccf4bde5268@linux.dev>


> On 02/13/26 20:27 Pierre-Louis Bossart <pierre-louis.bossart@linux.dev> wrote:
> Subject: Re: [PATCH v1 RESEND] SoundWire: Allow Prepare command for Simplified_CP_SM
> 
> > That's because it _IS_ a good response. If the part is reporting
> > NotFinished=0, then it's good to go and we don't need to treat it as a
> > timeout. The timeout is caused by the deadlock that Pierre mentioned.
> > Full CP_SM will always timeout because that code is holding the bus
> > lock, which blocks the interrupt handler.
> >
> > Ignoring the timeout if NotFinished=0 was a workaround until I found
> > time to fix the interrupt handling. Otherwise full CP_SM would never
> > work.
> >
> > We've now decided to replace that code with a polling loop instead of
> > using interrupts.
> 
> IOW the suggestion would be to use Richard's patch and force the drive to
> use a regular state machine.
> see https://github.com/thesofproject/linux/pull/5649
I checked this PR. Seems to be working as expected. But,

> 
> But if you want to keep following the CP_SM state machine, then you could
> indeed add the required write in a port_prep() routine.
> That'd fine as well, you'd be relying on what the core SoundWire stream
> management provides - namely a means to do device-specific stuff
> before/after port setup.
please ignore the patch in this thread.
I have sent a new patch to do handle this in codec driver itself
 ASoC: tas2783A: add explicit port prepare handling



      reply	other threads:[~2026-02-14 16:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09  7:09 [PATCH v1 RESEND] SoundWire: Allow Prepare command for Simplified_CP_SM Niranjan H Y
2026-02-09 14:43 ` Pierre-Louis Bossart
2026-02-10 11:08   ` Holalu Yogendra, Niranjan
2026-02-10 17:04     ` Pierre-Louis Bossart
2026-02-10 17:29       ` Richard Fitzgerald
2026-02-10 20:28         ` Pierre-Louis Bossart
2026-02-11 10:41           ` Richard Fitzgerald
2026-02-12 16:17             ` [EXTERNAL] " Holalu Yogendra, Niranjan
2026-02-12 16:28               ` Richard Fitzgerald
2026-02-13 14:56                 ` Pierre-Louis Bossart
2026-02-14 16:42                   ` Holalu Yogendra, Niranjan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc2fcd39b9f943a3b08c1af354ca6f09@ti.com \
    --to=niranjan.hy@ti.com \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=rf@opensource.cirrus.com \
    --cc=sandeepk@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=shumingf@realtek.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox