From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org,
kai.vehmanen@linux.intel.com, seppo.ingalsuo@linux.intel.com,
stable@vger.kernel.org, niranjan.hy@ti.com,
ckeepax@opensource.cirrus.com, sbinding@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: soc-ops: Correct the max value for clamp in soc_mixer_reg_to_ctl()
Date: Wed, 17 Dec 2025 12:40:39 +0000 [thread overview]
Message-ID: <bc6f3e66-ca9b-4ba3-bbe1-5ef31c373e6d@opensource.cirrus.com> (raw)
In-Reply-To: <56411df9-3253-439a-b8eb-75c5b0175a7a@linux.intel.com>
On 17/12/2025 12:38 pm, Péter Ujfalusi wrote:
>
>
> On 17/12/2025 14:36, Richard Fitzgerald wrote:
>> On 17/12/2025 12:20 pm, Péter Ujfalusi wrote:
>>>
>>>
>>> On 17/12/2025 14:16, Mark Brown wrote:
>>>> On Wed, Dec 17, 2025 at 02:06:23PM +0200, Peter Ujfalusi wrote:
>>>>> In 'normal' controls the mc->min is the minimum value the register can
>>>>> have, the mc->max is the maximum (the steps between are max - min).
>>>>
>>>> Have you seen:
>>>>
>>>> https://lore.kernel.org/r/20251216134938.788625-1-
>>>> sbinding@opensource.cirrus.com
>>>
>>> No, I tried to look for possible fixes for this, but have not found it.
>>>
>>> I think my one liner is a bit simpler with the same result, but I'll let
>>> people decide which is better (and test on Cirrus side)
>>>
>> Does it pass the kunit tests for SX controls?
>> The ASoC kunit tests have specific tests for SX controls.
>> The original patch failed those tests, but it was merged anyway.
>
> It passes my manual tests on cs42l43, not sure how to run the unit-test
> for SX, can you by chance test this?
>
The easiest option is to run them from your kernel build tree like this:
make mrproper
./tools/testing/kunit/kunit.py run
--kunitconfig=tools/testing/kunit/configs/all_tests.config
next prev parent reply other threads:[~2025-12-17 12:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 12:06 [PATCH] ASoC: soc-ops: Correct the max value for clamp in soc_mixer_reg_to_ctl() Peter Ujfalusi
2025-12-17 12:16 ` Mark Brown
2025-12-17 12:20 ` Péter Ujfalusi
2025-12-17 12:36 ` Richard Fitzgerald
2025-12-17 12:38 ` Péter Ujfalusi
2025-12-17 12:40 ` Richard Fitzgerald [this message]
2025-12-17 12:44 ` Mark Brown
2025-12-17 13:01 ` Péter Ujfalusi
2025-12-17 13:16 ` Richard Fitzgerald
2025-12-17 13:54 ` Péter Ujfalusi
2025-12-17 13:56 ` Mark Brown
2025-12-17 13:59 ` Péter Ujfalusi
2025-12-17 14:00 ` Mark Brown
2025-12-17 14:19 ` Péter Ujfalusi
2025-12-17 14:22 ` Mark Brown
2025-12-17 13:18 ` Mark Brown
2025-12-17 12:17 ` Péter Ujfalusi
2025-12-17 12:47 ` Charles Keepax
2025-12-17 13:13 ` Péter Ujfalusi
2025-12-17 13:42 ` Charles Keepax
2025-12-17 14:31 ` Péter Ujfalusi
2025-12-17 15:00 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc6f3e66-ca9b-4ba3-bbe1-5ef31c373e6d@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=sbinding@opensource.cirrus.com \
--cc=seppo.ingalsuo@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox