From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, venkataprasad.potturu@amd.com,
Mario.Limonciello@amd.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms
Date: Mon, 20 Jan 2025 23:03:59 +0530 [thread overview]
Message-ID: <bde9986f-9519-4e2d-b435-dc15a96f299c@amd.com> (raw)
In-Reply-To: <e5d8c2a5-98cf-46f1-b942-8792289ec363@sirena.org.uk>
On 20/01/25 22:38, Mark Brown wrote:
> On Mon, Jan 20, 2025 at 03:31:09PM +0530, Vijendar Mukunda wrote:
>
>> This patch adds common PCI driver to bind to this device and get PCI
>> resources for ACP7.0 & ACP7.1 platforms.
>> + ret = pci_request_regions(pci, "AMD ACP6.2 audio");
>> + if (ret < 0) {
>> + dev_err(&pci->dev, "pci_request_regions failed\n");
>> + goto disable_pci;
>> + }
> Looks like there's a cut'n'paste that needed to be updated here! I'd
> suggest there might be some chance for code sharing, but I suspect the
> amount of code is so trivial that it's not really worth it.
Will update it. As platform specific changes exists along with
standard pci driver probe sequence, I don't think we really need to
go for common code here. Same time, We will improve code by
implementing common helper functions where ever it can be applicable.
next prev parent reply other threads:[~2025-01-20 17:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 10:01 [PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 01/23] ASoC: amd: add register header file for ACP7.0 platform Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms Vijendar Mukunda
2025-01-20 17:08 ` Mark Brown
2025-01-20 17:33 ` Mukunda,Vijendar [this message]
2025-01-20 10:01 ` [PATCH V2 03/23] ASoC: amd: acp70: add acp init and de-init functions Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 04/23] ASoC: amd: acp70: add logic for scanning acp child devices Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 05/23] ASoC: amd: acp70: create platform devices for acp child nodes Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 06/23] ASoC: amd: acp70: enable driver build for ACP7.0 platform Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 07/23] ASoC: amd: acp70: add acp pdm platform driver Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 08/23] ASoC: amd: acp70: add acp pdm driver dma ops and dai ops Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 09/23] ASoC: amd: acp70: add acp soundwire dma driver Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 10/23] ASoC: amd: update ACP7.0 KConfig option description Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 11/23] ASoC: amd: acp70: add soundwire dma driver dma ops Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 12/23] ASoC: amd: acp70: add acp ip interrupt handler Vijendar Mukunda
2025-01-20 17:55 ` Mark Brown
2025-01-20 18:18 ` Mukunda,Vijendar
2025-01-20 18:39 ` Mark Brown
2025-01-20 18:47 ` Mario Limonciello
2025-01-20 19:28 ` Mark Brown
2025-01-21 5:22 ` Mukunda,Vijendar
2025-01-20 10:01 ` [PATCH V2 13/23] ASoC: amd: acp70: add acp pdm driver pm ops Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 14/23] ASoC: amd: acp70: add pm ops support for soundwire dma driver Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 15/23] ASoC: amd: acp70: add acp driver pm ops support Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 16/23] ASoC: amd: acp70: enable wake capability for acp pci driver Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 17/23] ASoC: amd: acp70: add soundwire wake interrupt handling Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 18/23] ASoC: amd: acp70: enable soundwire host wake irq mask Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 19/23] ASoC: amd: acp70: enable acp pme enable during acp init sequence Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 20/23] ASoC: amd: acp70: create a device node for soundwire machine driver Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 21/23] ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1 platforms Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 22/23] ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform Vijendar Mukunda
2025-01-20 10:01 ` [PATCH V2 23/23] ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support Vijendar Mukunda
2025-02-10 16:29 ` [PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support Mark Brown
2025-02-10 16:46 ` Mukunda,Vijendar
2025-02-10 18:04 ` Mark Brown
2025-02-11 8:21 ` Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde9986f-9519-4e2d-b435-dc15a96f299c@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox