Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Banajit Goswami <bgoswami@quicinc.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 4/6] ASoC: codecs: wsa884x: parse port-mapping information
Date: Thu, 27 Jun 2024 14:58:45 +0200	[thread overview]
Message-ID: <bfc333a1-52da-4e4e-9917-09840ac5ebea@linaro.org> (raw)
In-Reply-To: <20240626-port-map-v1-4-bd8987d2b332@linaro.org>

On 27/06/2024 13:55, Srinivas Kandagatla wrote:
> Add support to parse static master port map information from device tree.
> This is required for correct port mapping between soundwire device and
> master ports.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>   sound/soc/codecs/wsa884x.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/sound/soc/codecs/wsa884x.c b/sound/soc/codecs/wsa884x.c
> index a9767ef0e39d..72ff71bfb827 100644
> --- a/sound/soc/codecs/wsa884x.c
> +++ b/sound/soc/codecs/wsa884x.c
> @@ -1887,6 +1887,14 @@ static int wsa884x_probe(struct sdw_slave *pdev,
>   	wsa884x->sconfig.direction = SDW_DATA_DIR_RX;
>   	wsa884x->sconfig.type = SDW_STREAM_PDM;
>   
> +	/**
> +	 * Port map index starts with 0, however the data port for this codec
> +	 * are from index 1
> +	 */
> +	if (of_property_read_u32_array(dev->of_node, "qcom,port-mapping", &pdev->m_port_map[1],
> +					WSA884X_MAX_SWR_PORTS))
> +		dev_info(dev, "Static Port mapping not specified\n");
> +
>   	pdev->prop.sink_ports = GENMASK(WSA884X_MAX_SWR_PORTS, 0);
>   	pdev->prop.simple_clk_stop_capable = true;
>   	pdev->prop.sink_dpn_prop = wsa884x_sink_dpn_prop;
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

  parent reply	other threads:[~2024-06-27 12:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 11:55 [PATCH 0/6] ASoC: codecs: wsa88xx: add support for static port mapping srinivas.kandagatla
2024-06-27 11:55 ` [PATCH 1/6] ASoC: dt-bindings: wsa883x: Document port mapping property srinivas.kandagatla
2024-06-27 12:05   ` Krzysztof Kozlowski
2024-06-27 11:55 ` [PATCH 2/6] ASoC: codecs: wsa883x: parse port-mapping information Srinivas Kandagatla
2024-06-27 12:06   ` Krzysztof Kozlowski
2024-06-27 13:36   ` Dmitry Baryshkov
2024-06-27 14:34     ` Srinivas Kandagatla
2024-06-27 11:55 ` [PATCH 3/6] ASoC: dt-bindings: wsa8840: Document port mapping property Srinivas Kandagatla
2024-06-27 12:06   ` Krzysztof Kozlowski
2024-06-27 11:55 ` [PATCH 4/6] ASoC: codecs: wsa884x: parse port-mapping information Srinivas Kandagatla
2024-06-27 12:07   ` Krzysztof Kozlowski
2024-06-27 12:58   ` Neil Armstrong [this message]
2024-06-27 13:38   ` Dmitry Baryshkov
2024-06-27 14:16     ` Krzysztof Kozlowski
2024-06-27 15:12       ` Dmitry Baryshkov
2024-06-27 14:34     ` Srinivas Kandagatla
2024-06-27 15:11       ` Dmitry Baryshkov
2024-06-27 11:55 ` [PATCH 5/6] arm64: dts: x1e80100-crd: fix wsa soundwire port mapping Srinivas Kandagatla
2024-06-27 12:07   ` Krzysztof Kozlowski
2024-06-27 11:55 ` [PATCH 6/6] arm64: dts: x1e80100-qcp: " Srinivas Kandagatla
2024-06-27 12:07   ` Krzysztof Kozlowski
2024-06-27 12:51 ` [PATCH 0/6] ASoC: codecs: wsa88xx: add support for static " Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfc333a1-52da-4e4e-9917-09840ac5ebea@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=bgoswami@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox