Re: [PATCH v4 2/6] ASoC: sdw_utils: add ES9356 in codec_info_list

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 3/27/26 10:59, Zhang Yi wrote:
> Add ES9356 in codec_info_list
> 
> Signed-off-by: Zhang Yi <zhangyi@everest-semi.com>
> ---
>  sound/soc/sdw_utils/soc_sdw_utils.c | 49 +++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
> 
> diff --git a/sound/soc/sdw_utils/soc_sdw_utils.c b/sound/soc/sdw_utils/soc_sdw_utils.c
> index 75658148d..ea0e8969d 100644
> --- a/sound/soc/sdw_utils/soc_sdw_utils.c
> +++ b/sound/soc/sdw_utils/soc_sdw_utils.c
> @@ -885,6 +885,55 @@ struct asoc_sdw_codec_info codec_info_list[] = {
>  		},
>  		.aux_num = 1,
>  	},
> +	{
> +		.part_id = 0x9356,
> +		.name_prefix = "es9356",

that part will conflict with the in-flight change to add the vendor id, no?

> +		.version_id = 3,
> +		.dais = {
> +			{
> +				.direction = {true, false},
> +				.dai_name = "es9356-sdp-aif1",
> +				.dai_type = SOC_SDW_DAI_TYPE_JACK,
> +				.dailink = {SOC_SDW_JACK_OUT_DAI_ID, SOC_SDW_UNUSED_DAI_ID},
> +				.init = asoc_sdw_es9356_init,
> +				.exit = asoc_sdw_es9356_exit,
> +				.rtd_init = asoc_sdw_es9356_rtd_init,
> +				.controls = generic_jack_controls,
> +				.num_controls = ARRAY_SIZE(generic_jack_controls),
> +				.widgets = generic_jack_widgets,
> +				.num_widgets = ARRAY_SIZE(generic_jack_widgets),
> +			},
> +			{
> +				.direction = {false, true},
> +				.dai_name = "es9356-sdp-aif4",
> +				.dai_type = SOC_SDW_DAI_TYPE_MIC,
> +				.dailink = {SOC_SDW_UNUSED_DAI_ID, SOC_SDW_DMIC_DAI_ID},
> +				.rtd_init = asoc_sdw_es9356_dmic_rtd_init,
> +				.widgets = generic_dmic_widgets,
> +				.num_widgets = ARRAY_SIZE(generic_dmic_widgets),
> +			},
> +			{
> +				.direction = {false, true},
> +				.dai_name = "es9356-sdp-aif2",
> +				.dai_type = SOC_SDW_DAI_TYPE_JACK,
> +				.dailink = {SOC_SDW_UNUSED_DAI_ID, SOC_SDW_JACK_IN_DAI_ID},
> +			},
> +			{
> +				.direction = {true, false},
> +				.dai_name = "es9356-sdp-aif3",
> +				.component_name = "es9356",
> +				.dai_type = SOC_SDW_DAI_TYPE_AMP,
> +				.dailink = {SOC_SDW_AMP_OUT_DAI_ID, SOC_SDW_UNUSED_DAI_ID},
> +				.init = asoc_sdw_es9356_amp_init,
> +				.rtd_init = asoc_sdw_es9356_spk_rtd_init,
> +				.controls = generic_spk_controls,
> +				.num_controls = ARRAY_SIZE(generic_spk_controls),
> +				.widgets = generic_spk_widgets,
> +				.num_widgets = ARRAY_SIZE(generic_spk_widgets),
> +			},
> +		},
> +		.dai_num = 4,
> +	},
>  	{
>  		.part_id = 0xaaaa, /* generic codec mockup */
>  		.name_prefix = "sdw_mockup_mmulti-function",