Re: [PATCH 00/20] ASoC: Intel: avs: Update machine board card names

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2025-04-07 2:41 PM, Amadeusz Sławiński wrote:
> As discussed in user bug report [1] & [2], it was identified that HDA
> card provides wrong FE device numbers to be used with UCM, at the same
> time it was requested that we change card names to better names.
> 
> This patchset does that, by adding option for going back to old
> behaviour in first patch. Using existing way of enumerating FEs from
> topology in second patch. Then setting new names in all cards while
> providing fallback to old name. Only exception is probe card, which is
> used for debug purposes only, where we just directly rename card.
> 
> Do note that patch 2, will require updated topologies if topology
> exposes more than 1 FE on card. Old topologies didn't assign id field
> and it defaulted to 0, however when we use this field by setting
> snd_soc_component_driver::use_dai_pcm_id field, we need topologies with
> distinct values in FEs. Necessary changes are provided in avsdk and
> avs-topology-xml repositories ([4] & [5]). linux-firmware update will
> follow as soon as this changeset is merged.
This was quite a task :) For the entire series:

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

> [1]
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219654
> [2]
> Link: https://github.com/alsa-project/alsa-ucm-conf/pull/499
> [3]
> Link: https://lore.kernel.org/linux-sound/20250127144445.2739017-1-amadeuszx.slawinski@linux.intel.com/
> [4]
> https://github.com/thesofproject/avsdk/commit/a879c8ae4ba7be53b8ed528da1361a8c62475b6e
> [5]
> https://github.com/thesofproject/avs-topology-xml/commit/9b94d52cbc5c1e07c8d9503c86329cd62ea4c9e7
> https://github.com/thesofproject/avs-topology-xml/commit/bdbc8d6ba9ea6db67daed9cbbaed3c23ff112ecb
> 
> Amadeusz Sławiński (20):
>    ASoC: Intel: avs: boards: Add Kconfig option for obsolete card names
>    ASoC: Intel: avs: Use topology information for endpoint numbers
>    ASoC: Intel: avs: boards: Change da7219 card name
>    ASoC: Intel: avs: boards: Change DMIC card name
>    ASoC: Intel: avs: boards: Change es8336 card name
>    ASoC: Intel: avs: boards: Change hdaudio card name
>    ASoC: Intel: avs: boards: Change sspX-loopback card name
>    ASoC: Intel: avs: boards: Change max98357a card name
>    ASoC: Intel: avs: boards: Change max98373 card name
>    ASoC: Intel: avs: boards: Change max98927 card name
>    ASoC: Intel: avs: boards: Change nau8825 card name
>    ASoC: Intel: avs: boards: Change pcm3168a card name
>    ASoC: Intel: avs: boards: Change probe card name
>    ASoC: Intel: avs: boards: Change rt274 card name
>    ASoC: Intel: avs: boards: Change rt286 card name
>    ASoC: Intel: avs: boards: Change rt298 card name
>    ASoC: Intel: avs: boards: Change rt5514 card name
>    ASoC: Intel: avs: boards: Change rt5663 card name
>    ASoC: Intel: avs: boards: Change rt5682 card name
>    ASoC: Intel: avs: boards: Change ssm4567 card name
> 
>   sound/soc/intel/avs/avs.h              |  2 +-
>   sound/soc/intel/avs/board_selection.c  | 37 +++++++++++++++++++++++---
>   sound/soc/intel/avs/boards/Kconfig     |  8 ++++++
>   sound/soc/intel/avs/boards/da7219.c    |  9 ++++++-
>   sound/soc/intel/avs/boards/dmic.c      | 10 ++++++-
>   sound/soc/intel/avs/boards/es8336.c    |  9 ++++++-
>   sound/soc/intel/avs/boards/hdaudio.c   | 23 +++++++++++++---
>   sound/soc/intel/avs/boards/i2s_test.c  | 13 +++++++--
>   sound/soc/intel/avs/boards/max98357a.c |  9 ++++++-
>   sound/soc/intel/avs/boards/max98373.c  |  9 ++++++-
>   sound/soc/intel/avs/boards/max98927.c  |  9 ++++++-
>   sound/soc/intel/avs/boards/nau8825.c   |  9 ++++++-
>   sound/soc/intel/avs/boards/pcm3168a.c  | 14 +++++++++-
>   sound/soc/intel/avs/boards/probe.c     |  3 ++-
>   sound/soc/intel/avs/boards/rt274.c     |  9 ++++++-
>   sound/soc/intel/avs/boards/rt286.c     |  9 ++++++-
>   sound/soc/intel/avs/boards/rt298.c     |  9 ++++++-
>   sound/soc/intel/avs/boards/rt5514.c    |  9 ++++++-
>   sound/soc/intel/avs/boards/rt5663.c    |  9 ++++++-
>   sound/soc/intel/avs/boards/rt5682.c    |  9 ++++++-
>   sound/soc/intel/avs/boards/ssm4567.c   |  9 ++++++-
>   sound/soc/intel/avs/pcm.c              | 13 ++++++---
>   sound/soc/intel/avs/probes.c           |  2 +-
>   sound/soc/intel/avs/utils.h            | 16 +++++++++--
>   24 files changed, 224 insertions(+), 34 deletions(-)
> 
> 
> base-commit: 3a0f0a4355df0240485ed62b6bd6afa5b3e689c5