From: "Ryan Walklin" <ryan@testtoast.com>
To: "Icenowy Zheng" <uwu@icenowy.me>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>, "Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>
Cc: linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
"Chris Morgan" <macromorgan@hotmail.com>
Subject: Re: [PATCH v2 5/5] ASoC: sun4i-codec: change h616 card name
Date: Tue, 28 Jan 2025 14:10:30 +1300 [thread overview]
Message-ID: <c5ade280-d607-4870-a4e0-7d455f6bc6c3@app.fastmail.com> (raw)
In-Reply-To: <db43243ea653073d223e640f064cd480da7e2cf5.camel@icenowy.me>
On Sun, 26 Jan 2025, at 8:51 PM, Icenowy Zheng wrote:
> 在 2025-01-25星期六的 20:00 +1300，Ryan Walklin写道：
Hi Icenowy, thanks for reviewing!
>> - card->name = "H616 Audio Codec";
>> + card->name = "h616-audio-codec";
>> + card->long_name = "H616 Audio Codec";
>
> I think it's part of the userspace API that should be kept stable.
I don't have a strong feeling about this change, but can anyone suggest any other options for how to manage this name being picked up by UCM as a file path? I guess the UCM paths can include spaces, but this is slightly unwieldy and may break if proper escaping is not done.
Would appreciate if any of the ALSA devs could weigh in on best practice here.
Regards,
Ryan
next prev parent reply other threads:[~2025-01-28 1:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-25 7:00 [PATCH v2 0/5] ASoC: sun4i-codec: add headphone dectection for Anbernic RG35XX devices Ryan Walklin
2025-01-25 7:00 ` [PATCH v2 1/5] ASoC: dt-bindings: sun4i-a10-codec: add hp-det-gpios Ryan Walklin
2025-01-27 19:12 ` Rob Herring (Arm)
2025-01-25 7:00 ` [PATCH v2 2/5] ASoC: sun4i-codec: correct dapm widgets and controls for h616 Ryan Walklin
2025-01-25 7:00 ` [PATCH v2 3/5] ASoC: sun4i-codec: support hp-det-gpios property Ryan Walklin
2025-01-25 7:00 ` [PATCH v2 4/5] arm64: dts: allwinner: h700: Add hp-det-gpios for Anbernic RG35XX Ryan Walklin
2025-01-25 7:00 ` [PATCH v2 5/5] ASoC: sun4i-codec: change h616 card name Ryan Walklin
2025-01-26 7:51 ` Icenowy Zheng
2025-01-28 1:10 ` Ryan Walklin [this message]
2025-02-14 20:52 ` Ryan Walklin
2025-02-11 21:05 ` [PATCH v2 0/5] ASoC: sun4i-codec: add headphone dectection for Anbernic RG35XX devices Philippe Simons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ade280-d607-4870-a4e0-7d455f6bc6c3@app.fastmail.com \
--to=ryan@testtoast.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macromorgan@hotmail.com \
--cc=perex@perex.cz \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox