Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Bard Liao <yung-chuan.liao@linux.intel.com>,
	broonie@kernel.org, tiwai@suse.de
Cc: linux-sound@vger.kernel.org, bard.liao@intel.com,
	peter.ujfalusi@linux.intel.com,
	ranjani.sridharan@linux.intel.com
Subject: Re: [PATCH 0/3]ASoC: SOF: Intel: reserve link DMA for sdw bpt stream
Date: Tue, 3 Feb 2026 14:16:48 +0100	[thread overview]
Message-ID: <c5ce3d0b-ea28-405d-b705-f9494f25dfcc@linux.dev> (raw)
In-Reply-To: <20260203114027.3742558-1-yung-chuan.liao@linux.intel.com>

On 2/3/26 12:40, Bard Liao wrote:
> Currently, hda_sdw_bpt_dma_prepare() get a HDA stream and use the link
> DMA but doesn't reserve it. It works fine because we assume the
> SwoundWire BPT will not run with audio streams simultaneously. Create
> and use the new helpers to reserve the link DMA and allow running BPT
> and audio stream simultaneously.
> 
> Bard Liao (3):
>   ASoC: SOF: Intel: add hda_dsp_stream_pair_get/put helpers
>   ASoC: SOF: Intel: add hda_dma_prepare/cleanup helpers
>   ASoC: SOF: Intel: hda-sdw-bpt: support simultaneous audio and BPT
>     streams

For the record this solution has two issues not documented in any commit message.

a) this will not work in 'dspless' mode, where the link DMA is not enabled. That's probably fine given that no one used that mode in production, but that's a software restriction that you will not be able to undo.

b) this raise the question of how bandwidth will be managed. The premise of BPT is that it uses all the bus bandwidth to guarantee predictable firmware download times. If the available bandwidth is restricted by other audio streams, then mechanically the startup latency will be increased and vary - or you will have to run the bus at a higher frequency to provision enough bandwidth for BPT but that means higher power consumption. Or you will have to change the bus clock dynamically which is possible at the hardware level for SDCA parts but not legacy ones.

I am not going to lay on the tracks for this low-level set of changes, but you'll have to address the b) opens for future contributions.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

>  sound/soc/sof/intel/hda-loader.c  |  94 +-----------------
>  sound/soc/sof/intel/hda-sdw-bpt.c |   5 +-
>  sound/soc/sof/intel/hda-stream.c  | 157 +++++++++++++++++++++++++++++-
>  sound/soc/sof/intel/hda.h         |  11 +++
>  4 files changed, 171 insertions(+), 96 deletions(-)
> 


  parent reply	other threads:[~2026-02-03 13:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 11:40 [PATCH 0/3]ASoC: SOF: Intel: reserve link DMA for sdw bpt stream Bard Liao
2026-02-03 11:40 ` [PATCH 1/3] ASoC: SOF: Intel: add hda_dsp_stream_pair_get/put helpers Bard Liao
2026-02-03 11:40 ` [PATCH 2/3] ASoC: SOF: Intel: add hda_dma_prepare/cleanup helpers Bard Liao
2026-02-03 11:40 ` [PATCH 3/3] ASoC: SOF: Intel: hda-sdw-bpt: support simultaneous audio and BPT streams Bard Liao
2026-02-03 13:16 ` Pierre-Louis Bossart [this message]
2026-02-04 12:05   ` [PATCH 0/3]ASoC: SOF: Intel: reserve link DMA for sdw bpt stream Liao, Bard
2026-02-04 12:00 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5ce3d0b-ea28-405d-b705-f9494f25dfcc@linux.dev \
    --to=pierre-louis.bossart@linux.dev \
    --cc=bard.liao@intel.com \
    --cc=broonie@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox