From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D68414D9E8 for ; Wed, 17 Apr 2024 20:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713386466; cv=none; b=J2e/bnwUZySYd2KScSCENL8uhlWECA4fnXlgyk4rDmeXlc4kYx3ZFi0c1+GMO3nqkNZZan3CsiR335J4+NDNSSacA6fRFrXzvFV5iM9+X/x0ORDCHJlXLsG4b203/e9geuY/cwf9xjsEITuTap8BzHExSDlFXDUocO4/KzNF04s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713386466; c=relaxed/simple; bh=ITiZ2fpq/HihRXMxMD+fOObCfd7iBh/mgSkX4vJZggY=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=IAbRMw9Ue+rA3p6aCWjADpArcEFibG0gGCXBVw/DaIR7JRY5dD/9umCiH+kCVPBXoQN0av/FbutGhKmMHJosvRNDkIITDHvB8xVZUjA7f5fez5gTN7oMWgOPEBSyS+HM4xZ5BuhJ2qUeOq9ljEjxjD+mWhDcU5BpdkXrYT8Vhrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mo2jhAhK; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mo2jhAhK" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a5269c3f9c7so4572666b.2 for ; Wed, 17 Apr 2024 13:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713386462; x=1713991262; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=RcVoTPuXW+WHmIbLPZ+MXT1yyVJDN45gbEWOWncMp6E=; b=mo2jhAhKuLqo9nNDGxiD6wu2fu42rCCq2XAl+eVVCTIMl0G052I4ZLqfqTLyyHArY7 CGYDjJwr5cIZp+0SICe+3FJhzyvOqg3/UNlwoK0GN1ysojIY1r+YYZlOO8rytQVXYR22 Uoxxh816CI5IbJ5YnTq4umpb6XhuYFi8triPXAeBJ4Zspw6DB41k+H+HiHY3+SbKZeeI SQPYDJKBFp3kSwqhmt/q6oIjGefc8XKvJ35xV+lkEfBbOkCmRRCuxOKVk5+BLHd+b0o+ n7ZtyFPdlNWfi+pTjX425dVslhhVcXvT4glaZHWMpDlRaEXborDk699qxeFGKHClsSIR j56Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713386462; x=1713991262; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RcVoTPuXW+WHmIbLPZ+MXT1yyVJDN45gbEWOWncMp6E=; b=OI77RXoOqwJ4DNFAfnXugxCqQBrSt29fhPpfZayzCgRWtW68GOK7h1BRlUP9BxvAe4 aR0poKA8AaXhDgxI8xR/sPPYBG+sLXD7/mVudmyAIf+JXBgu4DaR8PtWiLHICN7MSl3r HGDEbxCtqqgcO1dyafFb6unyiKceuSduiu3f8VL+SoyaIeaGeIx+NULeuIFEC2bxwVpb wTxuVxJiiDg4OoK53ewDmtuQVJJ7QcvT6uuiKrw3aZtrDqQJsrhppJn9RwbjWLu8rqKr jdu/ploiHWj3xb5Xj5Su3ms3mEjfh8FhKicf5ZcnbT0JWjTl1N4CDLXBF010NojDdbVD fjIg== X-Forwarded-Encrypted: i=1; AJvYcCV7Em0nuT2COST2o5qOWTUWZUUiIRcuiY6N0j62Gybd19cY7tjosy0gR8y8+pjghpZccrNkO5TfbAQpwTdYtQbbuhGA4pqi7NvdVro= X-Gm-Message-State: AOJu0Yx/9XHkygP3Kpo66FZNae6maY3ujOE+WiWAB0F/JtISc8RlpY04 2/COPXr2fKvJsDk4rKPQpsNaPQwzJ3u4qg2ypqFQLZppr/71yeGz9xSnu2xRvxQ= X-Google-Smtp-Source: AGHT+IFi6XKPbjhVKyt/GrjH0V0LKXLGUkLoERph9F8lMB5GSwa7YKRSVRyIuDtKGhFSjbvQdag8Hw== X-Received: by 2002:a17:906:5ac6:b0:a52:2772:b9cb with SMTP id x6-20020a1709065ac600b00a522772b9cbmr362840ejs.24.1713386462247; Wed, 17 Apr 2024 13:41:02 -0700 (PDT) Received: from [192.168.45.55] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id k23-20020a17090627d700b00a556adcf5fbsm19193ejc.116.2024.04.17.13.40.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Apr 2024 13:41:00 -0700 (PDT) Message-ID: Date: Wed, 17 Apr 2024 22:40:57 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] ASoC: codecs: wcd937x: add wcd937x codec driver To: Prasad Kumpatla References: <20240416063600.309747-3-quic_mohs@quicinc.com> Content-Language: en-US Cc: alsa-devel@alsa-project.org, Liam Girdwood , Mark Brown , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Srinivas Kandagatla , Jaroslav Kysela , Banajit Goswami , quic_rohkumar@quicinc.com, Takashi Iwai , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Trilok Soni , Bjorn Andersson , Alex Elder From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20240416063600.309747-3-quic_mohs@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16.04.2024 8:35 AM, Prasad Kumpatla wrote: > This patch adds basic SoundWire codec driver to support for > WCD937X TX and RX devices. > > WCD937x has Multi Button Headset Control hardware to support Headset > insertion, type detection, 8 headset buttons detection, Over Current > detection and Impedence measurements. > This patch adds support for this using wcd-mbhc apis. > --- > sound/soc/codecs/wcd937x.c | 1583 ++++++++++++++++++++++++++++++++++++ > sound/soc/codecs/wcd937x.h | 617 ++++++++++++++ > 2 files changed, 2200 insertions(+) > create mode 100644 sound/soc/codecs/wcd937x.c > create mode 100644 sound/soc/codecs/wcd937x.h > > diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c > new file mode 100644 > index 000000000000..d29cb56630c7 > --- /dev/null > +++ b/sound/soc/codecs/wcd937x.c > @@ -0,0 +1,1583 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved. Well this is pretty disappointing This is clearly built upon my commit [1] (which itself is built upon QC downstream, for which it retains the QuIC copyright), which can be seen e.g. in the funny bitwise ORing in wcd937x_set_micbias_data or the precise comments/function ordering.. Please at least include the Linaro copyright. Konrad [1] https://git.codelinaro.org/konrad.dybcio/linux/-/commit/a62f9c6fc53d4249e9de57898821e5ca4d2e7ca2