RE: [PATCH] ASoC: SDCA: support Q7.8 volume format

["Shuming [范書銘]" <shumingf@realtek.com>]

> > +static int sdca_soc_q78_reg_to_ctl(struct soc_mixer_control *mc, unsigned
> int reg_val,
> > +                             unsigned int mask, unsigned int shift,
> > +int max) {
> > +     int val = reg_val;
> > +
> > +     if (WARN_ON(!mc->shift))
> 
> We should use the function argument for shift in these functions.

It is intentional to do this. 
The patch only uses the 'shift' field to store the step value and the 'rshift' field remains zero.
Therefore, we could reuse the function 'soc_put_volsw' and generate the correct result for stereo volume.

> >  static int soc_mixer_reg_to_ctl(struct soc_mixer_control *mc, unsigned int
> reg_val,
> >                               unsigned int mask, unsigned int shift,
> > int max)  { @@ -202,14 +232,22 @@ static int soc_put_volsw(struct
> > snd_kcontrol *kcontrol,
> >       unsigned int val2 = 0;
> >       bool double_r = false;
> >       int ret;
> > +     unsigned int (*ctl_to_reg)(struct soc_mixer_control *, int,
> > + unsigned int, unsigned int, int);
> 
> Would be nice to put this at the top of the variable list, given the length.

Will fix