From: Mark Brown <broonie@kernel.org>
To: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
srinivas.kandagatla@oss.qualcomm.com
Subject: Re: [PATCH v1 2/3] ASoC: codecs: lpass-va-macro: Switch to PM clock framework for runtime PM
Date: Tue, 14 Apr 2026 13:04:10 +0100 [thread overview]
Message-ID: <c71d2ce2-e6e7-43a7-bfdd-e1cc1008b3b2@sirena.org.uk> (raw)
In-Reply-To: <20260413121824.375473-3-ajay.nandam@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
On Mon, Apr 13, 2026 at 05:48:23PM +0530, Ajay Kumar Nandam wrote:
> struct va_macro *va = dev_get_drvdata(dev);
> int ret;
>
> - ret = clk_prepare_enable(va->mclk);
> - if (ret) {
> - dev_err(va->dev, "unable to prepare mclk\n");
> + ret = pm_clk_resume(dev);
> + if (ret)
> return ret;
> - }
> -
>
> regcache_cache_only(va->regmap, false);
> - regcache_sync(va->regmap);
>
> - return 0;
> + return regcache_sync(va->regmap);
Same issue here (and the cache only mode needs to be reenabled), and
likely also in the third patch thouh I didn't check that yet.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-14 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 12:18 [PATCH v1 0/3] ASoC: qcom: lpass: Switch VA/WSA macros to PM clock framework Ajay Kumar Nandam
2026-04-13 12:18 ` [PATCH v1 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM Ajay Kumar Nandam
2026-04-14 8:46 ` Konrad Dybcio
2026-04-14 12:02 ` Mark Brown
2026-04-16 11:57 ` Ajay Kumar Nandam
2026-04-13 12:18 ` [PATCH v1 2/3] ASoC: codecs: lpass-va-macro: " Ajay Kumar Nandam
2026-04-14 12:04 ` Mark Brown [this message]
2026-04-16 11:58 ` Ajay Kumar Nandam
2026-04-13 12:18 ` [PATCH v1 3/3] ASoC: codecs: lpass-wsa-macro: Guard optional NPL clock rate programming Ajay Kumar Nandam
2026-04-14 8:47 ` Konrad Dybcio
2026-04-16 11:55 ` Ajay Kumar Nandam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c71d2ce2-e6e7-43a7-bfdd-e1cc1008b3b2@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox