From: Markus Elfring <Markus.Elfring@web.de>
To: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
Mark Brown <broonie@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Basavaraj Hiregoudar <Basavaraj.Hiregoudar@amd.com>,
Jaroslav Kysela <perex@perex.cz>, Jiawei Wang <me@jwang.link>,
Liam Girdwood <lgirdwood@gmail.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Sunil-kumar Dommati <Sunil-kumar.Dommati@amd.com>,
Syed Saba Kareem <Syed.SabaKareem@amd.com>,
Takashi Iwai <tiwai@suse.com>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
end.to.start@mail.ru
Subject: Re: [PATCH] ASoC: amd: yc: Fix the wrong return value
Date: Mon, 9 Dec 2024 14:46:38 +0100 [thread overview]
Message-ID: <cabca893-74f3-441a-ad27-9589819cb1f4@web.de> (raw)
In-Reply-To: <20241209101320.970571-1-venkataprasad.potturu@amd.com>
…
> Add a condition check to jump to check the DMI entries
> incase of ACP driver fail to read ACPI _WOV method.
in case? failure?
…
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -578,14 +578,19 @@ static int acp6x_probe(struct platform_device *pdev)
>
> handle = ACPI_HANDLE(pdev->dev.parent);
> ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
> - if (!ACPI_FAILURE(ret))
> + if (!ACPI_FAILURE(ret)) {
> wov_en = dmic_status;
> + if (!wov_en)
> + return -ENODEV;
> + } else {
> + /* Incase of ACPI method read failure then jump to check_dmi_entry */
> + goto check_dmi_entry;
> + }
>
> if (is_dmic_enable && wov_en)
> platform_set_drvdata(pdev, &acp6x_card);
…
Is there a need to adjust another condition check accordingly?
Regards,
Markus
next prev parent reply other threads:[~2024-12-09 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 10:13 [PATCH] ASoC: amd: yc: Fix the wrong return value Venkata Prasad Potturu
2024-12-09 13:46 ` Markus Elfring [this message]
2024-12-10 6:24 ` potturu venkata prasad
2024-12-10 7:28 ` Markus Elfring
2024-12-10 8:37 ` potturu venkata prasad
2024-12-10 14:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cabca893-74f3-441a-ad27-9589819cb1f4@web.de \
--to=markus.elfring@web.de \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=end.to.start@mail.ru \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=me@jwang.link \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox