From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86521267B94; Thu, 11 Sep 2025 06:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757572319; cv=none; b=lvOOkxZ9nQJZBCT8pvPN3Noc6mjk19tx2/zbCoa4bI5yh1mEuX1QX832mxFpfz2HZWZpKd93JxWjOG6udkKUKSXOi4cPWm9LySkD7VhKReCrSc7NNUglmCnXpRUVEmh6lnxiAEhlj9KDgSj1XYBAtbc1rjiZYthmE0OtaT1/VJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757572319; c=relaxed/simple; bh=IOFTFKA236+E0sFOssT7ukZoMvaWI5Ipl6F5c9xNPpY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jzzYYPMjcWNDizoKM8cthwA1gRHBRrBF0WZBuvMFFRet4pTBq4e/0sFYhCyTI80mHcnT1MotSbqnEZ8D3s4+bRS+577jopDDyh5X4CGK6hW1zOHkYkBZi4wY6IuHu5sc5UZmHMVEUcFAhw/jsUtJScafad7NBCzArtFGoXxZss0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hxvOzzTP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hxvOzzTP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A3F3C4CEF1; Thu, 11 Sep 2025 06:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757572319; bh=IOFTFKA236+E0sFOssT7ukZoMvaWI5Ipl6F5c9xNPpY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hxvOzzTPrWJfHY1oiNtjm3sYJu9SH9ApqF6WB5J0u7gx391929DrmYtB0KR63OuLV 9gtIUFfMxmb2/JN5EjSzQ4Yzh4kVRd010VZrYKk8pvLGsUDiQewcxbrib7Exd1gNsS cOnd84rBQg33mId/Wk9C94x6vx6l36wliIrz9XTI2W/KJxVcPPztbWiJeDPLTF5oa5 ptTmKv0OUiJFGauSzliSzO7BeVNJISKtgpZCWcIHb3DoX5TbxMiuvjq0u259uT7y+R vlG89CfjB5/WXq9bSk3ThWY5ihRPo3ilKY9wVCDbn0jpnP9+zsVdksnErxB/MOUlxU lg5AG8TgSEVdQ== Message-ID: Date: Thu, 11 Sep 2025 08:31:54 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/7] soundwire: qcom: add support for v3.1.0 To: Srinivas Kandagatla , Alexey Klimov , vkoul@kernel.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, srini@kernel.org, yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-sound@vger.kernel.org References: <20250904105616.39178-1-srinivas.kandagatla@oss.qualcomm.com> <7b7db1d2-5f53-4b08-920d-67a57d975313@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <7b7db1d2-5f53-4b08-920d-67a57d975313@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/09/2025 07:49, Srinivas Kandagatla wrote: > > > On 9/11/25 1:52 AM, Alexey Klimov wrote: >> On Thu Sep 4, 2025 at 11:56 AM BST, Srinivas Kandagatla wrote: >>> This patch series adds support for Qualcomm Soundwire Controller >>> version v3.1.0. >>> As part for adding this support, a new macro of_property_read_u8_index() >>> is added so that we can remove the qcom,din-ports and qcom,dout-ports. >>> As v3.1.0 supports more than 17 soundwire ports. Also due to change in >>> the register offsets, new entries are added to the variant data. >>> >>> Tested this patchset on X14s and Glymur reference platform. >> >> Well, I don't have any Glymur devices and no idea what is >> x14s (I guess some laptop), but I picked the series locally to test >> on sm8550, it seems there are some generic changes, and >> qcom-soundwire probe failed: >> >> remoteproc remoteproc1: powering up adsp >> remoteproc remoteproc1: Booting fw image qcom/sm8550/adsp.mbn, size 8364 >> remoteproc remoteproc1: remote processor adsp is now up >> qcom,fastrpc 6800000.remoteproc:glink-edge.fastrpcglink-apps-dsp.-1.-1: no reserved DMA memory for FASTRPC >> PDR: Indication received from msm/adsp/audio_pd, state: 0x1fffffff, trans-id: 1 >> platform 6800000.remoteproc:glink-edge:fastrpc:compute-cb@3: Adding to iommu group 12 >> qcom,apr 6800000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:1 >> platform 6800000.remoteproc:glink-edge:fastrpc:compute-cb@4: Adding to iommu group 13 >> qcom,apr 6800000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:2 >> PDR: Indication received from msm/adsp/charger_pd, state: 0x1fffffff, trans-id: 1 >> platform 6800000.remoteproc:glink-edge:fastrpc:compute-cb@5: Adding to iommu group 14 >> platform 6800000.remoteproc:glink-edge:fastrpc:compute-cb@6: Adding to iommu group 15 >> platform 6800000.remoteproc:glink-edge:fastrpc:compute-cb@7: Adding to iommu group 16 >> qcom-apm gprsvc:service:2:1: CMD timeout for [1001021] opcode >> platform 6800000.remoteproc:glink-edge:gpr:service@1:dais: Adding to iommu group 17 >> va_macro 6d44000.codec: qcom,dmic-sample-rate dt entry missing >> qcom-soundwire 6d30000.soundwire: probe with driver qcom-soundwire failed with error -75 >> sched: DL replenish lagged too much >> platform sound: deferred probe pending: snd-sc8280xp: WCD Playback: codec dai not found >> >> Are there any dependencies I am missing? > > Looks like there is a bug in sm8550 dts, its adding incorrect number of > ports, which is why we are seeing this error. Yes, the DTS has incorrect value for number of ports. Few others have as well. It's known (for me :) ), but I never bothered to fix it because it is not that trivial - need also port config for missing node. Best regards, Krzysztof