From: Luke Jones <luke@ljones.dev>
To: Stefan Binding <sbinding@opensource.cirrus.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v1 2/7] ALSA: hda: cs35l41: Support additional ASUS ROG 2023 models
Date: Thu, 21 Dec 2023 21:41:26 +1300 [thread overview]
Message-ID: <cc07eae78c07e09e378cf37494b0f973905130ff.camel@ljones.dev> (raw)
In-Reply-To: <20231218151221.388745-3-sbinding@opensource.cirrus.com>
On Mon, 2023-12-18 at 15:12 +0000, Stefan Binding wrote:
> Add new model entries into configuration table.
>
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> ---
> sound/pci/hda/cs35l41_hda_property.c | 36
> ++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> index f90423ded85d..a0d808ed640a 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -42,6 +42,24 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
> * in the ACPI. The Reset GPIO is also valid, so we can use the
> Reset defined in _DSD.
> */
> { "103C89C6", SPI, 2, INTERNAL, { CS35L41_RIGHT,
> CS35L41_LEFT, 0, 0 }, -1, -1, -1, 1000, 4500, 24 },
> + { "10431433", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> + { "10431463", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> + { "10431473", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> + { "10431483", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> + { "10431493", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> + { "104314D3", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> + { "104314E3", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> + { "10431503", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> + { "10431533", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> + { "10431573", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> + { "10431663", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> + { "104317F3", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> + { "10431C9F", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> + { "10431CAF", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> + { "10431CCF", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> + { "10431CDF", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> + { "10431CEF", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> + { "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> {}
> };
>
Very good to see this work done. I have tested on 3 models and each one
has very good sound now. Many thanks!
> @@ -316,6 +334,24 @@ static const struct cs35l41_prop_model
> cs35l41_prop_model_table[] = {
> { "CLSA0100", NULL, lenovo_legion_no_acpi },
> { "CLSA0101", NULL, lenovo_legion_no_acpi },
> { "CSC3551", "103C89C6", generic_dsd_config },
> + { "CSC3551", "10431433", generic_dsd_config },
> + { "CSC3551", "10431463", generic_dsd_config },
> + { "CSC3551", "10431473", generic_dsd_config },
> + { "CSC3551", "10431483", generic_dsd_config },
> + { "CSC3551", "10431493", generic_dsd_config },
> + { "CSC3551", "104314D3", generic_dsd_config },
> + { "CSC3551", "104314E3", generic_dsd_config },
> + { "CSC3551", "10431503", generic_dsd_config },
> + { "CSC3551", "10431533", generic_dsd_config },
> + { "CSC3551", "10431573", generic_dsd_config },
> + { "CSC3551", "10431663", generic_dsd_config },
> + { "CSC3551", "104317F3", generic_dsd_config },
> + { "CSC3551", "10431C9F", generic_dsd_config },
> + { "CSC3551", "10431CAF", generic_dsd_config },
> + { "CSC3551", "10431CCF", generic_dsd_config },
> + { "CSC3551", "10431CDF", generic_dsd_config },
> + { "CSC3551", "10431CEF", generic_dsd_config },
> + { "CSC3551", "10431D1F", generic_dsd_config },
> {}
> };
>
next prev parent reply other threads:[~2023-12-21 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 15:12 [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD Stefan Binding
2023-12-18 15:12 ` [PATCH v1 1/7] ALSA: hda: cs35l41: Add config table to support many laptops " Stefan Binding
2023-12-18 15:12 ` [PATCH v1 2/7] ALSA: hda: cs35l41: Support additional ASUS ROG 2023 models Stefan Binding
2023-12-21 8:41 ` Luke Jones [this message]
2023-12-18 15:12 ` [PATCH v1 3/7] ALSA: hda/realtek: Add quirks for " Stefan Binding
2023-12-18 15:12 ` [PATCH v1 4/7] ALSA: hda: cs35l41: Support additional ASUS Zenbook 2022 Models Stefan Binding
2023-12-18 15:12 ` [PATCH v1 5/7] ALSA: hda/realtek: Add quirks for " Stefan Binding
2023-12-18 15:12 ` [PATCH v1 6/7] ALSA: hda: cs35l41: Support additional ASUS Zenbook 2023 Models Stefan Binding
2023-12-18 15:12 ` [PATCH v1 7/7] ALSA: hda/realtek: Add quirks for " Stefan Binding
2023-12-18 17:48 ` [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc07eae78c07e09e378cf37494b0f973905130ff.camel@ljones.dev \
--to=luke@ljones.dev \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox