From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7014015D5BB for ; Tue, 7 May 2024 18:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715105776; cv=none; b=TuuEqe7BJIFbwqYlAhYIWVf1z1pzIPLqreG76EnNO1S8/UOwAH6uRhXlY2oOAdkOdXPa8Q4OlIr6oJ54BCD/DxHXXUEjy9ZrPVtnae/0CP0Rd+envwrR6lRKjxfB99cjyIna8GBGFuXfCtIzxDScl311mYAmZecU9t76qtK0hC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715105776; c=relaxed/simple; bh=z56DW4uwWXSfy2S2WxG5hWfb4HBVtScM8Dx6WGp0vzQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lkwrvn8hSONx3WPgzFpb9X/nJHQk1g+Wz7Fh14eYTkJHPHldIebX25hShgNWEFKnAdb0xO0VaRf/yT2JF+v9W1IUMYzWhnhB6sDk912Qqm8J9ihkbr2mTkTZTpzTjSF28N7TVZKqf4yRZ10REBFZWlmh6FVxi06+h1a7Hc/Nxl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uUPaU451; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uUPaU451" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5206a5854adso2882756e87.0 for ; Tue, 07 May 2024 11:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715105773; x=1715710573; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=FtF0ji+6sky/klPDr1qbiHk0/IYbyBDqkgtl3xUgr1E=; b=uUPaU451gBRCru7K58KlFwbPu0GSW6LXsrl7rS8JaZcggCUa55tzMN0o18DTPqtDE1 5BjLzmFg8Qbfmjl2lNjqy1fQRqfe2FsGgPkrAKT9L3dgSJlPYyPBtR3jOwwWP8FAeQDE 1EWkXd+W6WJb5Om3ylSWXVGwk3ZNb9nKDMWLIFxYm1vgccrTww0wm58+a7dUmGjzw0ht Q4DpUUFJwHF7eGaJl99IWD8ZXlMh7jXXFZjTKeHfcKVl8S4cfZoLAOa6Ej8ZC+oIEfZ6 2fNmU+MikG4SyWdzN1MzjIjj6+HrZRbUOxI4o+/rqv0Eh5J3U55L7Bb3ck8IFK0Lx3KF 9ZCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715105773; x=1715710573; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FtF0ji+6sky/klPDr1qbiHk0/IYbyBDqkgtl3xUgr1E=; b=BkBQA5EzpJCWx1dsUPZfw+Gx8gLezeqXeBSnHe0azlwJjqkx+IY0YSNcuU/mQf2NBx iC2WfqPNzJaRE8c0sHlLUgYCSIWHLiAFZqBDJxxXCq03C5XgtJ0Nqo140JGBjNAS/9ab EdSSVor1XLiVaKUg9wbcV/CumbXdjlZVY5SHobln1tSBhL2+UhsQ9QES7wbGNG2iRQgU 5H8P5MEzAd5CLaOBjIAAgMLluqX13slTwqqv78rMUocRaQeJGl3r+0pmoxlFkD2qdGxq 05vceLUKvnBBg11r5nbpIAFfr/NmQ7KUMEKEKwGC4YM3S4P9DuDFW/6GIJ9kZICFhVDf IPLg== X-Forwarded-Encrypted: i=1; AJvYcCWHFo8OgJq/8s/mochN4IAGUU9rxTA+91bM1EyGoqe1phI7zZBZmo/zCsSeW98eZawUt8nnoNrGNb3RZebRrCHRNyMLN0qGxJejax8= X-Gm-Message-State: AOJu0YwZ12BwFHjGvWIFJrU2JuZ+l0hmrj/2bu8B7rfpVpeTVCzdV0CN 7kazr1WHY3mPUu2N5INBmiguh0h/+05vWM/l2Vo+GHAZ0o0SrAfpHYfit+JYkTo= X-Google-Smtp-Source: AGHT+IEaffYJmtcSK9ATh0btRVS69w4HbbXHVxQX/eRQ4nldlJt0OgzferuLRuqtQg0E9ut8Lg5j2w== X-Received: by 2002:ac2:4c0b:0:b0:51f:5d1a:7838 with SMTP id 2adb3069b0e04-5217c566a27mr187547e87.25.1715105772565; Tue, 07 May 2024 11:16:12 -0700 (PDT) Received: from [192.168.1.20] ([178.197.206.169]) by smtp.gmail.com with ESMTPSA id a26-20020a50ff1a000000b005728a272753sm6516812edu.67.2024.05.07.11.16.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 May 2024 11:16:11 -0700 (PDT) Message-ID: Date: Tue, 7 May 2024 20:16:09 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] ASoC: qcom: q6dsp: Implement proper channel mapping in Audioreach To: Srinivas Kandagatla , James Schulman , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Lars-Peter Clausen , =?UTF-8?Q?Nuno_S=C3=A1?= , Banajit Goswami Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240507-asoc-x1e80100-4-channel-mapping-v1-0-b12c13e0a55d@linaro.org> <20240507-asoc-x1e80100-4-channel-mapping-v1-2-b12c13e0a55d@linaro.org> <89cf75d8-1f85-43d8-9c33-377a04b36121@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <89cf75d8-1f85-43d8-9c33-377a04b36121@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/05/2024 15:25, Srinivas Kandagatla wrote: > > > On 07/05/2024 11:27, Krzysztof Kozlowski wrote: >> Instead of relying on default channel mapping in all Audioreach >> platforms, implement set_channel_map() callback to allow sound cards >> customize the mapping depending on needs. >> >> The channel mapping is set on frontend DAIs coming from the topology, >> not DTS, thus need to add DAI ops in topology dai_load() callback. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> sound/soc/qcom/qdsp6/audioreach.c | 2 +- >> sound/soc/qcom/qdsp6/audioreach.h | 1 + >> sound/soc/qcom/qdsp6/q6apm.c | 28 +++++++++++++++++++++++++++- >> sound/soc/qcom/qdsp6/q6apm.h | 8 ++++++++ >> sound/soc/qcom/qdsp6/topology.c | 12 ++++++++++++ >> 5 files changed, 49 insertions(+), 2 deletions(-) > Please use the existing q6dma_set_channel_map() and set the channel map > for the backend dai from machine driver, this should work. > > setting channels on FE is not a scalable one. > > Please take a look at some of the patches that I shared privately. > Ack Best regards, Krzysztof