From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nikola Jelic <nikola.jelic83@gmail.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
rwalton@cmlmicro.com
Subject: Re: [PATCH 1/2 V4] ASoC: dt-bindings: Add cmx655 codec
Date: Sun, 16 Feb 2025 14:06:49 +0100 [thread overview]
Message-ID: <cdbb8176-d109-4a31-9393-5e1ae6767170@kernel.org> (raw)
In-Reply-To: <20250216-fearless-arcane-koel-3c75ad@krzk-bin>
On 16/02/2025 14:03, Krzysztof Kozlowski wrote:
> On Fri, Feb 14, 2025 at 10:58:01PM +0100, Nikola Jelic wrote:
>> Signed-off-by: Nikola Jelic <nikola.jelic83@gmail.com>
>>
>> ---
>> V3 -> V4: review remarks
>
> You keep sending the same, not responding to comments and not fixing
> them. Still nothing improved - same problems as v1.
>
> What above changelog even mean?
>
> Please respond to the feedback, the best to the v1 which you received,
> that you acknowledge and implement it. If you have questions, then ask.
> Sending something with the same mistakes for 5th or 6th time means we do
> not understand each other.
To recap, feedback from v1 to respond to:
Please run scripts/checkpatch.pl and fix reported warnings. After that,
run also `scripts/checkpatch.pl --strict` and (probably) fix more
warnings. Some warnings can be ignored, especially from --strict run,
but the code here looks like it needs a fix. Feel free to get in touch
if the warning is not clear.
Feedback from v3: go to v3 and respond or implement. Your changelog
suggests nothing changed or it is just not precise enough.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-16 13:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 21:58 [PATCH 1/2 V4] ASoC: dt-bindings: Add cmx655 codec Nikola Jelic
2025-02-14 21:58 ` [PATCH 2/2 V5] ASoC: codecs: cmx655: Add CML's CMX655D codec Nikola Jelic
2025-02-16 13:04 ` Krzysztof Kozlowski
2025-02-16 13:03 ` [PATCH 1/2 V4] ASoC: dt-bindings: Add cmx655 codec Krzysztof Kozlowski
2025-02-16 13:06 ` Krzysztof Kozlowski [this message]
2025-03-21 22:22 ` [PATCH V6 1/2] " Nikola Jelic
2025-03-21 22:22 ` [PATCH V6 2/2] ASoC: codecs: cmx655: Add CML's CMX655D codec Nikola Jelic
2025-03-24 7:55 ` [PATCH V6 1/2] ASoC: dt-bindings: Add cmx655 codec Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdbb8176-d109-4a31-9393-5e1ae6767170@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nikola.jelic83@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=rwalton@cmlmicro.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox