From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, yung-chuan.liao@linux.intel.com,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
superm1@kernel.org, Sunil-kumar.Dommati@amd.com,
venkataprasad.potturu@amd.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: amd: acp: update dmic_num logic for acp pdm dmic
Date: Mon, 30 Mar 2026 20:41:30 +0530 [thread overview]
Message-ID: <cdd4acd5-8aa0-4eae-99b7-d6d47c61a80f@amd.com> (raw)
In-Reply-To: <03a53820-a076-42ed-9ab2-3877396f99f9@sirena.org.uk>
On 30/03/26 19:13, Mark Brown wrote:
> On Mon, Mar 30, 2026 at 12:50:27PM +0530, Vijendar Mukunda wrote:
>
>> +++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
>> @@ -535,11 +535,11 @@ static int mc_probe(struct platform_device *pdev)
>> " cfg-amp:%d", amp_num);
>> if (!card->components)
>> return -ENOMEM;
>> - if (mach->mach_params.dmic_num) {
>> + if (soc_sdw_quirk & ASOC_SDW_ACP_DMIC) {
> soc_card_dai_links_create() (which could perhaps use better namespacing)
> checks both dmic_num and the quirk. This doesn't seem properly joined
> up (and perhaps the code shouldn't be as spread out as it is)?
Need to drop the mach_params->dmic_num check in soc_card_dai_links_create().
Will push a separate patch for the same.
next prev parent reply other threads:[~2026-03-30 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 7:20 [PATCH 0/2] ASoC: amd: acp: update dmic_num logic for acp pdm dmic Vijendar Mukunda
2026-03-30 7:20 ` [PATCH 1/2] " Vijendar Mukunda
2026-03-30 13:43 ` Mark Brown
2026-03-30 15:11 ` Mukunda,Vijendar [this message]
2026-03-30 7:20 ` [PATCH 2/2] ASoC: amd: acp-sdw-legacy: rename the dmic component name Vijendar Mukunda
2026-03-30 19:14 ` [PATCH 0/2] ASoC: amd: acp: update dmic_num logic for acp pdm dmic Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdd4acd5-8aa0-4eae-99b7-d6d47c61a80f@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=superm1@kernel.org \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox