From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F7212F383; Wed, 8 May 2024 20:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715198836; cv=none; b=dB0bhJXAJxn7eAJOIazOvX7JqYdcGQ7xbEI3Pkycf+oETAJaMcf18KI80FH1JwgL4DBSiez/zHtO2jguUNx3tRwCRRKPbd/NJrQhFlGQVCduh9RR819vTggZBE4o2Oq6v7djsKCnEvKlg7xzndV6cQvyj6HoT2BmOtxgBoZizQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715198836; c=relaxed/simple; bh=4S6Kj4fjhCMZSsEZ0ttJOfsfwcZBTcBuK40ggT4QtZs=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=cwOH2lOqvDMvsoKmmT00z9fWGZP11+64DvaNPs/atVLc8Z4z97vag/7OlCHoLc3thZBkqXEE3fCksKG75OWVCZ3QJhncq+A7/8sw76s9Ma4Z21vLQkTKRRVG0s9TW4fHrsnk/EnSvynqtxRCRU26RFTkYBLvhEqGwEic8HH/4ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=TqOFDe5c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="TqOFDe5c" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 448GUPc9007934; Wed, 8 May 2024 20:06:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=zHOpw1FS1KuqIMtD/11gtpauLVx+8gzcq0ToefX61Sc=; b=Tq OFDe5c6EYYwzM8eYj9kQj/YjqNEVQH4icw+Pudw0I4DLs8riYVHKtznutuXMvfxP Y/aU/yC3wgEHwmTMDMebDcMB3LdPceu1QzFdLeLkpdzzzu4kcirnX+PlQ3NiLyu1 BiwPQru9P0xDviOkK3QGiENtP5WB7acQEHVvBilbezauzYTuXez4dRl7u84GpHDj H47YR1pjxc7G+o+uTOwqCAIUvsjRspzbpl2r0qAh3kcF8/yyWcSf+W+BegMG3BHQ eb4S8jS4ZYWt3KC3SvycIONok0TDU593+N4ET2bhpg6ncv3ypkTRFagGfHmNF+g9 XBfVB9Mqt3b7yHyZ5l9A== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3y09ejs1tj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 May 2024 20:06:38 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 448K6bhI013788 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 May 2024 20:06:37 GMT Received: from [10.110.126.205] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 8 May 2024 13:06:36 -0700 Message-ID: Date: Wed, 8 May 2024 13:06:36 -0700 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v21 38/39] ASoC: qcom: Populate SoC components string Content-Language: en-US To: Pierre-Louis Bossart , , , , , , , , , , , , , , , , CC: , , , , , , References: <20240507195116.9464-1-quic_wcheng@quicinc.com> <20240507195116.9464-39-quic_wcheng@quicinc.com> From: Wesley Cheng In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 0HWWRHzjF62aoHv3TqU5TLnPiHUa5_Sf X-Proofpoint-ORIG-GUID: 0HWWRHzjF62aoHv3TqU5TLnPiHUa5_Sf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-08_09,2024-05-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=992 malwarescore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405010000 definitions=main-2405080147 Hi Pierre, On 5/7/2024 2:40 PM, Pierre-Louis Bossart wrote: > > > On 5/7/24 14:51, Wesley Cheng wrote: >> For userspace to know about certain capabilities of the current platform >> card, add tags to the components string that it can use to enable support >> for that audio path. In case of USB offloading, the "usboffldplybk: 1" tag > > usboffloadplayback? > > same question as before, do we need spaces? > I think spaces are currently used as a delimiter, so I'll remove the spaces. > And if we have controls, why do we need component strings? The component > string is not dynamic to the best of my knowledge, this could be > problematic if the card is no longer capable of supporting this stream, > while a control can be updated at will. > Maybe I misunderstood your comment here: https://lore.kernel.org/linux-usb/925d7c03-c288-49a4-8bcd-395b32810d75@linux.intel.com/ At the time, I didn't include the kcontrols on the USB SND portion of it, which was added after this series. My interpretation was that there were userspace entities that could query for general information about what the card supports based on the components string, or sound card name. I treated this as an independent identifier, since the change to add the offload capable jack was present. Thanks Wesley Cheng