From: Markus Elfring <Markus.Elfring@web.de>
To: Bjorn Andersson <quic_bjorande@quicinc.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Chenyuan Yang <chenyuan0y@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Rohit kumar <quic_rohkumar@quicinc.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Takashi Iwai <tiwai@suse.com>,
Zichen Xie <zichenxie0106@gmail.com>,
Zijie Zhao <zzjas98@gmail.com>
Subject: Re: [PATCH] Fix possible NULL Pointer Dereference in 'asoc_qcom_lpass_cpu_platform_probe'
Date: Tue, 1 Oct 2024 14:48:54 +0200 [thread overview]
Message-ID: <cf8e2da5-818d-4783-a3c4-bb6aa62088f2@web.de> (raw)
In-Reply-To: <Zvrb+q28S/C4z2eH@hu-bjorande-lv.qualcomm.com>
> > A 'devm_kzalloc' in 'asoc_qcom_lpass_cpu_platform_probe' could possibly return NULL pointer.
> > NULL Pointer Dereference may be triggerred in 'asoc_qcom_lpass_cpu_platform_probe' without addtional check.
> > Add a null check for the returned pointer.
>
> Your description and patch looks good to me.
Interesting “view” …
> But please run git log on the changed file and add a prefix to your
> subject to match other changes to this file, and please wrap your commit
> message at 75 characters.
* How does your initial information fit to this patch review advice?
* Would you like to “tolerate” any typos (at the first glance)?
Regards,
Markus
next prev parent reply other threads:[~2024-10-01 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 1:15 [PATCH] Fix possible NULL Pointer Dereference in 'asoc_qcom_lpass_cpu_platform_probe' Gax-c
2024-09-30 16:33 ` Markus Elfring
2024-09-30 18:16 ` Mark Brown
2024-10-01 5:30 ` Markus Elfring
2024-09-30 17:12 ` [PATCH] " Bjorn Andersson
2024-10-01 12:48 ` Markus Elfring [this message]
2024-10-01 12:58 ` Mark Brown
2024-10-01 19:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf8e2da5-818d-4783-a3c4-bb6aa62088f2@web.de \
--to=markus.elfring@web.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chenyuan0y@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_bjorande@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=zichenxie0106@gmail.com \
--cc=zzjas98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox